gloas: encode Builder.version as a string in JSON/YAML - #42
Merged
Conversation
Beacon API JSON encodes integers as strings; lighthouse returns "version": "1" and unmarshaling into a bare uint8 fails, breaking every gloas BeaconState fetch (xatu-cannon's beaconValidators deriver errors with 'cannot unmarshal string into Go struct field builderJSON.version'). MarshalYAML also dropped the field entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beacon API JSON encodes integers as strings; lighthouse returns
"version": "1"and unmarshaling into a bareuint8fails, which breaks every gloasBeaconStateJSON fetch — xatu-cannon's beaconValidators deriver errors withcannot unmarshal string into Go struct field builderJSON.version of type uint8on glamsterdam-devnet-7.MarshalYAMLalso dropped the field entirely. Version is now marshaled/parsed as a string like the struct's other numeric fields, with a round-trip test.