single string tool response should just be string#81
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how tool response content is formatted in the Agent class to optimize for OpenAI API semantics, where single text responses can be represented as plain strings rather than arrays.
- Extracts tool content formatting logic into a dedicated
_format_tool_message_contentmethod - Returns plain strings for single text responses instead of always using arrays
- Maintains backwards compatibility by still returning arrays for multiple text items
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eval_protocol/pytest/default_agent_rollout_processor.py | Refactors tool message content formatting by extracting logic into a new method and optimizing single text responses |
| tests/pytest/test_tool_response_single_string.py | Adds comprehensive test coverage for the new tool content formatting behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| def _format_tool_message_content( | ||
| self, content: List[TextContent] | ||
| ) -> Union[str, List[ChatCompletionContentPartTextParam]]: |
There was a problem hiding this comment.
The return type annotation is missing the import for Union. Add 'from typing import Union' to the imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.