-
Notifications
You must be signed in to change notification settings - Fork 16
single string tool response should just be string #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import asyncio | ||
| from typing import List, Optional | ||
|
|
||
| from mcp.types import TextContent | ||
| from openai.types.chat.chat_completion_message import ( | ||
| ChatCompletionMessageToolCall, | ||
| FunctionCall, | ||
| ) | ||
|
|
||
| from eval_protocol.models import EvaluationRow, Message | ||
| from eval_protocol.pytest.default_agent_rollout_processor import Agent | ||
|
|
||
|
|
||
| class NoOpLogger: | ||
| def log(self, row: EvaluationRow) -> None: | ||
| return None | ||
|
|
||
| def read(self, row_id: Optional[str] = None) -> List[EvaluationRow]: | ||
| return [] | ||
|
|
||
|
|
||
| def test_tool_result_single_text_becomes_string(): | ||
| # Prepare a minimal evaluation row and agent | ||
| row = EvaluationRow(messages=[Message(role="user", content="use the tool")]) | ||
| agent = Agent(model="dummy", row=row, config_path="", logger=NoOpLogger()) | ||
|
|
||
| # Single text content becomes a plain string | ||
| single = [TextContent(type="text", text="single result")] | ||
| formatted = agent._format_tool_message_content(single) | ||
| assert isinstance(formatted, str) | ||
| assert formatted == "single result" | ||
|
|
||
| # Multiple text contents become a list of text parts | ||
| multiple = [ | ||
| TextContent(type="text", text="first"), | ||
| TextContent(type="text", text="second"), | ||
| ] | ||
| formatted_multi = agent._format_tool_message_content(multiple) | ||
| assert isinstance(formatted_multi, list) | ||
| assert [part["text"] for part in formatted_multi] == ["first", "second"] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type annotation is missing the import for Union. Add 'from typing import Union' to the imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol