SpalartAllmarasDDES turblence model together with neoPisoFoam#233
Open
HendriceH wants to merge 13 commits into
Open
SpalartAllmarasDDES turblence model together with neoPisoFoam#233HendriceH wants to merge 13 commits into
HendriceH wants to merge 13 commits into
Conversation
|
Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_233 |
HendriceH
force-pushed
the
feat/turbModel
branch
from
9a88232 to
75bc9bb
Compare
HendriceH
added
coordinated-merge
HendriceH
force-pushed
the
feat/turbModel
branch
from
76d55b2 to
ac2b5db
Compare
greole
reviewed
May 26, 2026
| ddtSchemes | ||
| { | ||
| default Euler; | ||
| // ddt(nfU) BDF1; |
Contributor
There was a problem hiding this comment.
please remove all the nfU field comments
Suggested change
| // ddt(nfU) BDF1; |
Contributor
There was a problem hiding this comment.
what is the difference to blockMeshDict.orig and do we need both?
Contributor
There was a problem hiding this comment.
these files are quite large. maybe we should add a Cmake traget to generate the meshes before running the tests. Otherwise, this will accumulate space and will become a pain.
Contributor
There was a problem hiding this comment.
I think the 0.02 folder should be removed.
After NeoN commit fa4fdf1055 ("make surface field contain only internal data"),
SurfaceField::internalVector() is sized mesh.nInternalFaces() only and boundary
face data moved to boundaryData().value(). divDevReff was missed during that
refactor: its boundary parallelFor iterated {nIF, tauF.size()} which now
degenerates to {nIntF, nIntF} (empty), silently dropping the boundary viscous
stress contribution and causing the SA-DDES wrapper test to fail the post-solve
U comparison at 1e-10.
Rewrite the boundary kernel to iterate {0, nBnd} and read from
tauF.boundaryData().value() with Sf[nIF + bfi], matching the pattern used by
gaussGreenGrad::computeGrad after the same refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of turbulence model
This PR is linked to exasim-project/NeoN#428.
It adds the following components:
neoPisoFoamsolver incorporating the turbulence equations