Addition of multiple features required for SA-DDES turbulence model by HendriceH · Pull Request #428 · exasim-project/NeoN

HendriceH · 2026-01-08T21:48:53Z

Implementation of turbulence model

This PR implements features required to run the SpalartAllmarasDDES turbulence model which is implemented in NeoFOAM PR 233 It consists of the following components:

Generally required for turbulence models

Tensor and symmTensor primitives
New Su type overload of source operator source (the available implementation before was only a Sp type source term that multiplies by the transport variable) to be able to add source terms that do not linearly depend on the turbulence transport variable
Functionality to pass generic fields to correctBoundaryConditions

github-actions · 2026-01-08T21:50:16Z

Thank you for your PR, here are some useful tips:

If this is your first PR, please add yourself to the AUTHORS.md file
Use labels to change the workflow behavior. Set auto-fix to automatically apply fixes, full-ci for a comprehensive set of tests and sanitizer runs, ready-for-review to show that you're done and need a review.
I deployed a test documentation to https://exasim-project.com/NeoN/Build_PR_428
For full-ci builds benchmark results are available at https://github.com/exasim-project/NeoFOAM-BenchmarkData/428
Also check if the GPU pipelines on https://gitlab-ce.lrz.de/greole/neon/-/jobs are successful.

HenningScheufler · 2026-02-14T17:38:19Z

+{
+
+template<typename ValueType>
+class SourceUTerm : public dsl::OperatorMixin<VolumeField<ValueType>>


SourceUTerm seems from the name to be specialized on the velocity field

Is there no implemenation of SourceTerm?

U here does not stand for velocity U, but for the different source types:
Sp - proportional part: term is multiplied with transport variable
Su - unconditional part: term is independant of tranport variable
in NeoN we currently only have Sp type sources.

greole

LGTM! But make sure the CI passes before merging and please add curly braces for the for loops.

greole · 2026-04-23T12:46:09Z

@@ -1,7 +1,8 @@
-# Version 0.3.0 (unreleased)
+# Version 0.3.0 (unreleased) 428


Suggested change

# Version 0.3.0 (unreleased) 428

# Version 0.3.0 (unreleased)

greole · 2026-04-23T12:48:25Z

+        auto hostSource = source.copyToHost();
+        auto hostSourceView = hostSource.view();
+        for (auto ii = 0; ii < hostSource.size(); ++ii)
+        {
+            REQUIRE(hostSourceView[ii] - 5 * one<TestType>() == TestType(0.0));
+        }


This can be handled with the new REQUIRE_THAT(exp, IsEqualTo(source));

greole · 2026-04-23T12:51:16Z

+        for (int k = 0; k < 6; ++k)
+            data_[k] = 0.0;


I dont know why claude is too lazy here to add curly braces. Without curly braces, it is very easy to break.

Suggested change

for (int k = 0; k < 6; ++k)

data_[k] = 0.0;

for (int k = 0; k < 6; ++k) {

data_[k] = 0.0;

}

greole · 2026-04-23T12:52:58Z

+        for (int k = 0; k < 6; ++k)
+            if (data_[k] != rhs.data_[k]) return false;


same here and all other for loops, please add curly braces for loop bodies even for a single line case.

greole · 2026-04-23T12:54:06Z

+    );
+}
+
+/** @brief T + T^T - (2/3)*tr(T)*I — matches OpenFOAM devTwoSymm, used for viscous stress */


Suggested change

/** @brief T + T^T - (2/3)*tr(T)*I — matches OpenFOAM devTwoSymm, used for viscous stress */

/** @brief T + T^T - (2/3)*tr(T)*I — used for viscous stress */

greole · 2026-04-23T16:49:47Z

I am unsure about this, i dont think it is the greatest design, but i can live with it for now. Maybe we can use std::variant<VolumeField<scalar>, VolumeField<Vec3>> to make it a bit more DRY and have just one std::unordered_map. (But maybe it is also too painfull to use)? @HenningScheufler what do you think?

…arbitrary fields into correctBoundaryConditions()

Addition of multiple features required for SA-DDES turbulence model

HendriceH self-assigned this Jan 8, 2026

HendriceH force-pushed the feat/turbModel branch 2 times, most recently from 1c56610 to 7f60dfd Compare January 20, 2026 21:00

HendriceH force-pushed the feat/turbModel branch from 0594fae to 629d643 Compare January 29, 2026 14:24

HendriceH force-pushed the feat/turbModel branch from 2628a6c to 7126416 Compare February 6, 2026 09:09

HendriceH requested review from HenningScheufler and greole February 9, 2026 08:56

HendriceH added the ready-for-review Set this label to indicate that the PR is ready for review label Feb 9, 2026

HendriceH mentioned this pull request Feb 9, 2026

SpalartAllmarasDDES turblence model together with neoPisoFoam exasim-project/NeoFOAM#233

Open

HenningScheufler marked this pull request as ready for review February 14, 2026 17:30

HenningScheufler reviewed Feb 14, 2026

View reviewed changes

HendriceH force-pushed the feat/turbModel branch 2 times, most recently from 9c8850a to 76194dd Compare April 20, 2026 16:33

HendriceH changed the title ~~Prototype of SA-DDES turbulence model~~ Addition of multiple features required for SA-DDES turbulence model Apr 22, 2026

greole approved these changes Apr 23, 2026

View reviewed changes

HendriceH force-pushed the feat/turbModel branch from 8204ba9 to f3a5c24 Compare April 28, 2026 22:14

Added tensors, symmTensors and Su type sourceTerm and option to pass …

2ecc2b5

…arbitrary fields into correctBoundaryConditions()

HendriceH force-pushed the feat/turbModel branch from 14f4f08 to 2ecc2b5 Compare April 29, 2026 09:01

HendriceH added 2 commits April 29, 2026 11:21

Fix naming due to CI issues

abebbaf

Fix clang tidy issues

0d7eb58

HendriceH merged commit 8f9e50b into develop Apr 29, 2026
20 of 21 checks passed

greole pushed a commit that referenced this pull request May 13, 2026

Merge pull request #428 from exasim-project/feat/turbModel

e02e70f

Addition of multiple features required for SA-DDES turbulence model

HendriceH deleted the feat/turbModel branch May 27, 2026 07:42

		@@ -1,7 +1,8 @@
		# Version 0.3.0 (unreleased)
		# Version 0.3.0 (unreleased) 428

		for (int k = 0; k < 6; ++k)
		if (data_[k] != rhs.data_[k]) return false;

	/** @brief T + T^T - (2/3)tr(T)I — matches OpenFOAM devTwoSymm, used for viscous stress */
	/** @brief T + T^T - (2/3)tr(T)I — used for viscous stress */

Conversation

HendriceH commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementation of turbulence model

Generally required for turbulence models

Uh oh!

github-actions Bot commented Jan 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greole left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HendriceH commented Jan 8, 2026 •

edited

Loading