Skip to content

Comments

[Emile] [Redone] Building with tests#250

Merged
JPTIZ merged 4 commits intodevs/expertise/native-windowsfrom
devs/joaoantoniocardoso/emile/redone
Jul 6, 2020
Merged

[Emile] [Redone] Building with tests#250
JPTIZ merged 4 commits intodevs/expertise/native-windowsfrom
devs/joaoantoniocardoso/emile/redone

Conversation

@joaoantoniocardoso
Copy link
Contributor

@joaoantoniocardoso joaoantoniocardoso commented Jul 3, 2020

Turns out that emile doesn't need ecore, so I redone the work of PR #120 here, sending it directly to windows-native.

Test:

23/23 emile-suite               OK             0.10s

@joaoantoniocardoso joaoantoniocardoso self-assigned this Jul 3, 2020
@joaoantoniocardoso
Copy link
Contributor Author

joaoantoniocardoso commented Jul 3, 2020 •
edited
Loading

The commit 151682f is actually borrowed from PR #59 and I hope it doesn't lead to any conflict.

@Coquinho
Copy link
Contributor

Coquinho commented Jul 3, 2020

I got some errors while compiling it at our server:

[409/526] Compiling C objec...g@exe/eo_test_general.c.obj
ninja: build stopped: subcommand failed.                
ninja: Entering directory `C:\Users\Lucas\source\repos\ef
l2\build'                                               
[4/119] Compiling C object .../emile_cipher_openssl.c.obj
FAILED: src/lib/emile/c2cd62f@@emile@sha/emile_cipher_ope
nssl.c.obj                                              
clang-cl @src/lib/emile/c2cd62f@@emile@sha/emile_cipher_o
penssl.c.obj.rsp                                        
../src/lib/emile/emile_cipher_openssl.c(5,10): fatal erro
r: 'openssl/sha.h' file not found                       
#include <openssl/sha.h>                                
         ^~~~~~~~~~~~~~~                                
1 error generated.                                      
[5/119] Compiling C object ...@emile@sha/emile_main.c.obj
FAILED: src/lib/emile/c2cd62f@@emile@sha/emile_main.c.obj
                                                        
clang-cl @src/lib/emile/c2cd62f@@emile@sha/emile_main.c.o
bj.rsp                                                  
../src/lib/emile/emile_main.c(12,10): fatal error: 'opens
sl/ssl.h' file not found                                
#include <openssl/ssl.h>                                
         ^~~~~~~~~~~~~~~                                
1 error generated.

Is it a problem at my user? Any one got it too?

@joaoantoniocardoso
Copy link
Contributor Author

joaoantoniocardoso commented Jul 3, 2020

I got some errors while compiling it at our server:

[409/526] Compiling C objec...g@exe/eo_test_general.c.obj
ninja: build stopped: subcommand failed.                
ninja: Entering directory `C:\Users\Lucas\source\repos\ef
l2\build'                                               
[4/119] Compiling C object .../emile_cipher_openssl.c.obj
FAILED: src/lib/emile/c2cd62f@@emile@sha/emile_cipher_ope
nssl.c.obj                                              
clang-cl @src/lib/emile/c2cd62f@@emile@sha/emile_cipher_o
penssl.c.obj.rsp                                        
../src/lib/emile/emile_cipher_openssl.c(5,10): fatal erro
r: 'openssl/sha.h' file not found                       
#include <openssl/sha.h>                                
         ^~~~~~~~~~~~~~~                                
1 error generated.                                      
[5/119] Compiling C object ...@emile@sha/emile_main.c.obj
FAILED: src/lib/emile/c2cd62f@@emile@sha/emile_main.c.obj
                                                        
clang-cl @src/lib/emile/c2cd62f@@emile@sha/emile_main.c.o
bj.rsp                                                  
../src/lib/emile/emile_main.c(12,10): fatal error: 'opens
sl/ssl.h' file not found                                
#include <openssl/ssl.h>                                
         ^~~~~~~~~~~~~~~                                
1 error generated.

Is it a problem at my user? Any one got it too?

Yes, you need to fix the path for your openssl.
git clone https://github.com/openssl/openssl -> this openssl folder should be your OPENSSL_DIR.

@Coquinho
Copy link
Contributor

Coquinho commented Jul 6, 2020

Is it a problem at my user? Any one got it too?

Yes, you need to fix the path for your openssl.
git clone https://github.com/openssl/openssl -> this openssl folder should be your OPENSSL_DIR.

Ups, my bad, thanks now it works

Coquinho
Coquinho reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@Coquinho Coquinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

23/23 emile-suite               OK             0.11s

I will just run an additional test on CI before approving.

@Coquinho Coquinho self-requested a review July 6, 2020 14:47
Coquinho
Coquinho approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@Coquinho Coquinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, its working

joaoantoniocardoso and others added 4 commits July 6, 2020 17:41
@joaoantoniocardoso
Enabling emile
f509543
@joaoantoniocardoso
Fixing missing include directory for crypto on windows
c0f9704 
adding ssl lib to crypto dependency

Alternative using link_args instead dependencies

using compile_args instead of include_directories
@joaoantoniocardoso
Adding missing S_ISDIR symbol
c2b0599
@joaoantoniocardoso
Enabling and fixing Nuget dependencies
e24ca58
@joaoantoniocardoso joaoantoniocardoso force-pushed the devs/joaoantoniocardoso/emile/redone branch from 69b1378 to e24ca58 Compare July 6, 2020 20:42
@Coquinho Coquinho self-requested a review July 6, 2020 21:47
Coquinho
Coquinho approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@Coquinho Coquinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, github just bugged here. sorry

@JPTIZ JPTIZ merged commit 808fc10 into devs/expertise/native-windows Jul 6, 2020
@joaoantoniocardoso joaoantoniocardoso mentioned this pull request Jul 7, 2020
Merged
joaoantoniocardoso referenced this pull request Jul 8, 2020
@felipealmeida
win32: emile compilation with win32 and jpeg inclusion order
4da6841
felipealmeida pushed a commit that referenced this pull request Oct 26, 2020
@joaoantoniocardoso @felipealmeida
[Emile] [Redone] Building with tests (#250)
22a1443 
* Fixing missing include directory for crypto on windows

adding ssl lib to crypto dependency

Alternative using link_args instead dependencies

using compile_args instead of include_directories

* Enabling emile

* Adding missing S_ISDIR symbol

* Enabling and fixing Nuget dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felipealmeida felipealmeida Awaiting requested review from felipealmeida

@cauebs cauebs Awaiting requested review from cauebs

@ricardocvel ricardocvel Awaiting requested review from ricardocvel

3 more reviewers

@walac walac walac approved these changes

@JPTIZ JPTIZ JPTIZ approved these changes

@Coquinho Coquinho Coquinho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joaoantoniocardoso joaoantoniocardoso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaoantoniocardoso @Coquinho @walac @JPTIZ