Implementation for sys/stat.h by ricardocvel · Pull Request #59 · expertisesolutions/efl

ricardocvel · 2020-05-10T22:58:59Z

This PR aims to implement the function:

fstatat ()
for Windows;
and declare the functions in stat.h:
umask ()
chmod ()
(using the header: <corecrt_io.h> and <errno.h>)

Coquinho

Your implementation should be an evil_ not an unposix/, so please move stah{h,c} to evil/evil_stat.{h,c}.

src/lib/evil/unposix/sys/stat.c

Coquinho · 2020-05-15T18:01:42Z

how exactly can we test it?

src/lib/evil/stat.c

joaoantoniocardoso

I am changing my approval to be clear that some work still needs to be done.

src/lib/evil/evil_stat.h

joaoantoniocardoso

Almost there, just some minor changes for me.

Is there some way to test it?

src/lib/evil/evil_stat.h

src/lib/evil/evil_stat.c

src/lib/evil/evil_stat.h

Coquinho

Code seems fine to me, how can I test this?

src/lib/evil/evil_stat.c

src/lib/evil/evil_stat.h

Coquinho

How can I test this?

And another thing, should these new things be inside some #ifndef CYGWIN(don't remember if it's exactly like that) as this isn't needed when building with it, but only when building windows natively?

src/lib/evil/evil_stat.c

joaoantoniocardoso

#169 changed EAPI to EVIL_API

src/lib/evil/evil_stat.c

src/lib/evil/evil_stat.h

Update stat.h Update stat.c Update stat.h Update stat.c Update stat.h including Windows.h at WIN_LEAN_AND_MEAN. Co-authored-by: Lucas <Coquinho@users.noreply.github.com> moving stat. {h, c) for evil / evil stat. {h, c} deleting items, which were copied to another directory

…c' in lib/evil/meson.build

…pertisesolutions/efl into devs/expertise-ricardo/sys/stat.h

src/lib/evil/evil_stat.h

walac · 2020-07-09T13:55:32Z

src/lib/evil/evil_stat.c

+{
+   int r_fstatat;
+
+   if (pathname[1] == ':' && pathname[2] == '\\' || pathname[2] == '/' )


You must check the buffer size before accessing it.

walac · 2020-07-09T13:57:05Z

src/lib/evil/evil_stat.c

+        do
+        {
+           pathbuf_size += MAX_PATH;
+           pathbuf = realloc(pathbuf, pathbuf_size * sizeof(char));


The memory allocated here is never freed.

walac · 2020-07-09T13:57:23Z

src/lib/evil/evil_stat.c

+         }
+
+        size_str = strlen(pathbuf) + strlen(pathname);
+        char *path_complete = malloc(sizeof(char) * size_str + 1);


The memory allocated here is never freed.

walac · 2020-07-09T13:58:12Z

src/lib/evil/evil_stat.c

+        size_str = strlen(pathbuf) + strlen(pathname);
+        char *path_complete = malloc(sizeof(char) * size_str + 1);
+        strcpy(path_complete, pathbuf);
+        strcat(path_complete, pathname);


What if pathbuf doesn't end with a path separator?

walac · 2020-07-09T13:59:09Z

src/lib/evil/evil_stat.c

+        if (flags == AT_SYMLINK_NOFOLLOW)
+          r_fstatat = stat(pathname, statbuf);
+        else
+          r_fstatat = stat(pathname, statbuf);


Why the if both calls are exactly the same?

walac · 2020-07-09T14:00:14Z

src/lib/evil/evil_stat.c

+                 pathbuf[size_str + 1] = 0;
+                 break;
+              }
+         }


What about using _splitpath instead of a manual for loop?

walac · 2020-07-09T14:00:38Z

src/lib/evil/evil_stat.c

+        else
+          { 
+             r_fstatat = stat(path_complete, statbuf);
+          }


Why the if?

Coquinho

Hey guys, what do you think about breaking this in 2 PR? We could have one with the functions, which seems to still have some loose ends, and we can approve the definitions, as it seems there is no discussion there.

joaoantoniocardoso approved these changes May 15, 2020

View reviewed changes

Coquinho suggested changes May 15, 2020

View reviewed changes

src/lib/evil/unposix/sys/stat.c Outdated Show resolved Hide resolved

src/lib/evil/unposix/sys/stat.c Outdated Show resolved Hide resolved

ricardocvel force-pushed the devs/expertise-ricardo/sys/stat.h branch 3 times, most recently from 5f9f866 to 62d2389 Compare May 19, 2020 17:59

walac assigned walac and ricardocvel Jun 4, 2020

ricardocvel force-pushed the devs/expertise-ricardo/sys/stat.h branch from 62d2389 to 4235c4f Compare June 5, 2020 19:13

ricardocvel changed the base branch from devs/felipealmeida/fix-eina-dll-export to devs/expertise/native-windows June 8, 2020 17:44

ricardocvel force-pushed the devs/expertise-ricardo/sys/stat.h branch from 4235c4f to 598bc10 Compare June 16, 2020 13:06

joaoantoniocardoso reviewed Jun 16, 2020

View reviewed changes

src/lib/evil/stat.c Outdated Show resolved Hide resolved

joaoantoniocardoso suggested changes Jun 16, 2020

View reviewed changes

joaoantoniocardoso reviewed Jun 16, 2020

View reviewed changes

src/lib/evil/evil_stat.h Outdated Show resolved Hide resolved

joaoantoniocardoso self-requested a review June 16, 2020 15:56

ricardocvel force-pushed the devs/expertise-ricardo/sys/stat.h branch from 187ed15 to 700df59 Compare June 16, 2020 16:20

joaoantoniocardoso suggested changes Jun 16, 2020

View reviewed changes

src/lib/evil/evil_stat.h Outdated Show resolved Hide resolved

src/lib/evil/evil_stat.c Outdated Show resolved Hide resolved

src/lib/evil/evil_stat.h Outdated Show resolved Hide resolved

src/lib/evil/evil_stat.h Outdated Show resolved Hide resolved

JPTIZ added this to the Natively Compile in Windows milestone Jun 16, 2020

ricardocvel force-pushed the devs/expertise-ricardo/sys/stat.h branch 2 times, most recently from a1ad61f to c506a45 Compare June 17, 2020 12:30

joaoantoniocardoso requested review from Coquinho and joaoantoniocardoso June 17, 2020 17:06

Coquinho reviewed Jun 18, 2020

View reviewed changes

joaoantoniocardoso suggested changes Jun 23, 2020

View reviewed changes

src/lib/evil/evil_stat.c Outdated Show resolved Hide resolved

src/lib/evil/evil_stat.c Outdated Show resolved Hide resolved

ricardocvel requested a review from joaoantoniocardoso June 24, 2020 15:39

joaoantoniocardoso approved these changes Jun 24, 2020

View reviewed changes

joaoantoniocardoso mentioned this pull request Jun 24, 2020

[Evil] EAPI -> EVIL_API #169

Merged

ricardocvel requested a review from Coquinho June 24, 2020 15:43

Coquinho reviewed Jun 24, 2020

View reviewed changes

src/lib/evil/evil_stat.h Outdated Show resolved Hide resolved

Coquinho reviewed Jun 24, 2020

View reviewed changes

walac suggested changes Jun 25, 2020

View reviewed changes

joaoantoniocardoso suggested changes Jun 25, 2020

View reviewed changes

src/lib/evil/evil_stat.c Outdated Show resolved Hide resolved

src/lib/evil/evil_stat.c Outdated Show resolved Hide resolved

src/lib/evil/evil_stat.h Outdated Show resolved Hide resolved

ricardocvel and others added 8 commits June 25, 2020 14:57

Windows:sys/stat.h:changes for tests Windows compatibility

fe4ab56

Include chmod and umask

a50025d

implementation of the fstatat () function

cfe5040

replacing <windows.h> with "evil_private.h" and including 'evil_stat.…

a8fa408

…c' in lib/evil/meson.build

inclusion of EAPI in evil_stat.c

5c8ca71

replacement of EAPI with EVIL_API

3c9df9a

deleted fstatat64 () and added guard _MSC_VER

6f33c48

ricardocvel force-pushed the devs/expertise-ricardo/sys/stat.h branch from 584be66 to 6f33c48 Compare June 25, 2020 21:06

ricardocvel added 2 commits June 26, 2020 11:04

Merge branch 'devs/expertise/native-windows' of https://github.com/ex…

89c457c

…pertisesolutions/efl into devs/expertise-ricardo/sys/stat.h

inclusion of the EVIL_API symbol

2bad3e7

Coquinho reviewed Jun 26, 2020

View reviewed changes

src/lib/evil/evil_stat.h Show resolved Hide resolved

adequacy of fstatat () for correct reading of absolute paths in windows

4c3d41f

joaoantoniocardoso mentioned this pull request Jul 3, 2020

[Emile] [Redone] Building with tests #250

Merged

solving problems with memory loss in evil_stat.c

6371434

walac suggested changes Jul 9, 2020

View reviewed changes

Coquinho reviewed Jul 13, 2020

View reviewed changes

Coquinho mentioned this pull request Jul 23, 2020

evil: Rework sys/stat.h port and add file system options definitions #338

Merged

Comments

Conversation

ricardocvel commented May 10, 2020

Uh oh!

Coquinho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Coquinho commented May 15, 2020

Uh oh!

Uh oh!

joaoantoniocardoso left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joaoantoniocardoso left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Coquinho left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Coquinho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaoantoniocardoso left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

walac Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

walac Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

walac Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

walac Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

walac Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

walac Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

walac Jul 9, 2020

Choose a reason for hiding this comment

Uh oh!

Coquinho left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Coquinho left a comment •

edited

Loading