Fix CI: Remove @nogrep from test-project generated files#5245
Closed
captbaritone wants to merge 1 commit intofacebook:mainfrom
Closed
Fix CI: Remove @nogrep from test-project generated files#5245captbaritone wants to merge 1 commit intofacebook:mainfrom
captbaritone wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D100831221. |
Contributor
|
@captbaritone merged this pull request in 2ae7e5a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit_nogrep_annotationfeature flag (added in 4e2fa21) defaults to disabled, so the compiler no longer emits@nogrepin generated artifacts@nogrep, causing the "Compiler output check" CI job to fail sincecheck-git-status.shdetects the mismatchTest plan