Skip to content

Fix CI: Remove @nogrep from test-project generated files#5245

Closed
captbaritone wants to merge 1 commit intofacebook:mainfrom
captbaritone:fix-ci-failures-20260414
Closed

Fix CI: Remove @nogrep from test-project generated files#5245
captbaritone wants to merge 1 commit intofacebook:mainfrom
captbaritone:fix-ci-failures-20260414

Conversation

@captbaritone
Copy link
Copy Markdown
Contributor

Summary

  • The emit_nogrep_annotation feature flag (added in 4e2fa21) defaults to disabled, so the compiler no longer emits @nogrep in generated artifacts
  • The test-project generated files still had @nogrep, causing the "Compiler output check" CI job to fail since check-git-status.sh detects the mismatch
  • Regenerated test-project files to match the compiler's current output

Test plan

  • CI should pass — the "Compiler output check" job will no longer detect changes after running the compiler on the test-project

The emit_nogrep_annotation feature flag (added in 4e2fa21)
defaults to disabled, so the compiler no longer emits @nogrep in
generated artifacts. Update the test-project files to match.
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 14, 2026

@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D100831221.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 14, 2026

@captbaritone merged this pull request in 2ae7e5a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant