[Feature] Learning rate scheduling callback from yaml#220
Draft
Xmaster6y wants to merge 8 commits intofacebookresearch:mainfrom
Draft
[Feature] Learning rate scheduling callback from yaml#220Xmaster6y wants to merge 8 commits intofacebookresearch:mainfrom
Xmaster6y wants to merge 8 commits intofacebookresearch:mainfrom
Conversation
Contributor
|
This PR is amazing thanks! There is a lot tho to discuss at once, would it be possible to shard into three:
Ty |
Contributor
Author
|
Sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It implements a callback
LRSchedulerCallbackto usetorchscheduling classes. For further extension, this callback is integrated within the config groupcallback. TheCallback&CallbackNotifierclasses were extended to enable callbacks to save data in the state dict (e.g. learning rate schedulers).It can be loaded using:
Depending on the class, additional arguments can be provided:
It can also be disabled:
or left empty:
To discuss
Maybe the defaults should be without any callback (can be left empty), yet the current LR scheduling doesn't change much training with basic configs. Maybe we should also save the optimizer within the experiment?
Defaults could also look like that: