fix: align review promises with implementation#144
Merged
Conversation
Contributor
SDP Auto-Attestation
Full attestation report{
"all_lint_pass": true,
"all_tests_pass": true,
"attestation_id": "ci-auto-144-a1ba9c97",
"beads_ids": [],
"branch": "fix/review-promises",
"changed_files": 11,
"coverage_ok": false,
"coverage_pct": 65.40300751879703,
"coverage_threshold": 80,
"generated_at": "2026-04-29T06:48:14Z",
"head_commit": "a1ba9c9711f79f8f5ae048f72e7b8fe5569bf6df",
"lint_results": [
{
"name": "go-vet",
"status": "pass"
},
{
"name": "golangci-lint",
"status": "pass"
}
],
"out_of_scope": [],
"scope_compliance": {
"ok": true,
"reason": "no linked workstreams — auto-attested from CI observation"
},
"test_results": [
{
"name": "go-test",
"status": "pass (5673 passed, 0 failed)"
}
],
"type": "ci-auto-attestation"
}
|
This reverts commit 85375c3.
a1ba9c9 to
e86dbd4
Compare
Contributor
SDP Auto-Attestation
Full attestation report{
"all_lint_pass": true,
"all_tests_pass": true,
"attestation_id": "ci-auto-144-e86dbd43",
"beads_ids": [],
"branch": "fix/review-promises",
"changed_files": 41,
"coverage_ok": false,
"coverage_pct": 65.23940520446097,
"coverage_threshold": 80,
"generated_at": "2026-04-29T15:55:42Z",
"head_commit": "e86dbd436574bc7a74c29147a16f4cab8dd3111c",
"lint_results": [
{
"name": "go-vet",
"status": "pass"
},
{
"name": "golangci-lint",
"status": "pass"
}
],
"out_of_scope": [],
"scope_compliance": {
"ok": true,
"reason": "no linked workstreams — auto-attested from CI observation"
},
"test_results": [
{
"name": "go-test",
"status": "pass (5735 passed, 0 failed)"
}
],
"type": "ci-auto-attestation"
}
|
Contributor
SDP Auto-Attestation
Full attestation report{
"all_lint_pass": true,
"all_tests_pass": true,
"attestation_id": "ci-auto-144-161861d1",
"beads_ids": [],
"branch": "fix/review-promises",
"changed_files": 43,
"coverage_ok": false,
"coverage_pct": 65.2460966542751,
"coverage_threshold": 80,
"generated_at": "2026-04-29T16:16:15Z",
"head_commit": "161861d175c6b0fc836d7aeade8faea2158d6f00",
"lint_results": [
{
"name": "go-vet",
"status": "pass"
},
{
"name": "golangci-lint",
"status": "pass"
}
],
"out_of_scope": [],
"scope_compliance": {
"ok": true,
"reason": "no linked workstreams — auto-attested from CI observation"
},
"test_results": [
{
"name": "go-test",
"status": "pass (5737 passed, 0 failed)"
}
],
"type": "ci-auto-attestation"
}
|
Contributor
SDP Auto-Attestation
Full attestation report{
"all_lint_pass": true,
"all_tests_pass": true,
"attestation_id": "ci-auto-144-f7f36511",
"beads_ids": [],
"branch": "fix/review-promises",
"changed_files": 45,
"coverage_ok": false,
"coverage_pct": 65.43345724907066,
"coverage_threshold": 80,
"generated_at": "2026-04-30T07:11:19Z",
"head_commit": "f7f3651119167fa0fd75b237d9458c7ee2f46ed3",
"lint_results": [
{
"name": "go-vet",
"status": "pass"
},
{
"name": "golangci-lint",
"status": "pass"
}
],
"out_of_scope": [],
"scope_compliance": {
"ok": true,
"reason": "no linked workstreams — auto-attested from CI observation"
},
"test_results": [
{
"name": "go-test",
"status": "pass (5740 passed, 0 failed)"
}
],
"type": "ci-auto-attestation"
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Beads