Skip to content

fix: align review promises with implementation #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fall-out-bug merged 11 commits into from
Apr 30, 2026
Merged

fix: align review promises with implementation #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
42d3ea1
fix: align review promises with implementation
fall-out-bug Apr 29, 2026
0c6838c
fix: address review gate findings
fall-out-bug Apr 29, 2026
cff23e9
fix: bound pi review model calls
fall-out-bug Apr 29, 2026
5bebf80
fix: preserve smoke test exit code
fall-out-bug Apr 29, 2026
fb8d68b
fix: stabilize pi review quorum
fall-out-bug Apr 29, 2026
85375c3
fix: pass pi review prompts by file
fall-out-bug Apr 29, 2026
e86dbd4
Revert "fix: pass pi review prompts by file"
fall-out-bug Apr 29, 2026
161861d
fix: bootstrap beads for doctor gate
fall-out-bug Apr 29, 2026
c0fa1bc
fix: reject adapter output path traversal
fall-out-bug Apr 29, 2026
88783c5
fix: fallback pi review timeouts
fall-out-bug Apr 29, 2026
f7f3651
fix: bound exec wait after timeouts
fall-out-bug Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .beads/interactions.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,3 +622,26 @@
{"id":"int-074ebd28","kind":"field_change","created_at":"2026-04-27T15:17:29.551261Z","actor":"Andrei","issue_id":"sdplab-hfk0.5","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Closed"}}
{"id":"int-790226b1","kind":"field_change","created_at":"2026-04-27T15:17:30.082941Z","actor":"Andrei","issue_id":"sdplab-hfk0.6","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Closed"}}
{"id":"int-795ef8c3","kind":"field_change","created_at":"2026-04-27T15:17:41.087254Z","actor":"Andrei","issue_id":"sdplab-hfk0","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Closed"}}
{"id":"int-7a35be2c","kind":"field_change","created_at":"2026-04-27T15:28:28.565628Z","actor":"Andrei","issue_id":"sdplab-q2cb","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"ACs verified: happy-path >=80%, GA >=60%, Beta >=50% advisory, Experimental exempt, tiered coverage in CI. 5 files changed (+250/-26)."}}
{"id":"int-d46329c8","kind":"field_change","created_at":"2026-04-27T15:32:43.346397Z","actor":"Andrei","issue_id":"sdplab-hjl7","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"ACs verified: all 16 direct deps justified by stable/operator owners, sigstore chain explained, 3 experimental-only deps flagged for F150-04 build-tag isolation, 9 duplicate patterns documented with fix/defer decisions. Audit report: docs/reviews/2026-04-27-dependency-audit.md"}}
{"id":"int-0fa6a060","kind":"field_change","created_at":"2026-04-27T16:07:43.402714Z","actor":"Andrei","issue_id":"sdplab-5r4x","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"ACs verified: goreleaser has 16 stable binaries only, 18 experimental cmd/ tagged with sdp_experimental, local builds work with -tags sdp_experimental, zero tests deleted, check-release-surface.sh has drift detection checks 5-7."}}
{"id":"int-aa75f447","kind":"field_change","created_at":"2026-04-27T16:25:05.402669Z","actor":"Andrei","issue_id":"sdplab-p4hj","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"ACs verified: formula installs sdp binary locally via brew install, test block verifies --help and scout --help, no lab-only binaries exposed, evidence at docs/evidence/F150-08-homebrew-dry-run.md, tap publishing deferred."}}
{"id":"int-dbfbc25a","kind":"field_change","created_at":"2026-04-27T16:33:50.460591Z","actor":"Andrei","issue_id":"sdplab-3uep","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"ACs verified: readiness report at docs/reference/release-readiness.md lists all shipped changes with evidence, remaining debt linked, lab-only surfaces named, release blockers separated (none), honest assessment included. Commit de9fd1af."}}
{"id":"int-1a882045","kind":"field_change","created_at":"2026-04-27T17:10:14.140499Z","actor":"Andrei","issue_id":"sdplab-nyr0","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"All 10 children closed. F150 product layering and release readiness complete: module migration, experimental isolation, telemetry consent, coverage policy, Homebrew formula, docs alignment, debt ledger. PR #142."}}
{"id":"int-f5044877","kind":"field_change","created_at":"2026-04-27T17:35:20.946964Z","actor":"Andrei","issue_id":"sdplab-kw3q.1","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#141"}}
{"id":"int-14e1e2de","kind":"field_change","created_at":"2026-04-27T17:35:21.414699Z","actor":"Andrei","issue_id":"sdplab-kw3q.2","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#141"}}
{"id":"int-80d53ed6","kind":"field_change","created_at":"2026-04-27T17:35:21.855607Z","actor":"Andrei","issue_id":"sdplab-kw3q.3","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#141"}}
{"id":"int-784c2170","kind":"field_change","created_at":"2026-04-27T17:35:22.275819Z","actor":"Andrei","issue_id":"sdplab-kw3q.4","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#141"}}
{"id":"int-837aa1c3","kind":"field_change","created_at":"2026-04-27T17:35:22.756998Z","actor":"Andrei","issue_id":"sdplab-kw3q.5","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#141"}}
{"id":"int-541bb0a4","kind":"field_change","created_at":"2026-04-27T17:35:38.251921Z","actor":"Andrei","issue_id":"sdplab-kw3q","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"merged via PR#141"}}
{"id":"int-523fe2bf","kind":"field_change","created_at":"2026-04-28T21:30:26.619267Z","actor":"Andrei","issue_id":"sdplab-njbd","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"merged via PR#142 — LimitsCache race fix included in F150 product layering PR"}}
{"id":"int-9b20b5f4","kind":"field_change","created_at":"2026-04-29T09:26:12.384358Z","actor":"Andrei","issue_id":"sdplab-tffu.1","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#143"}}
{"id":"int-c1d8ac97","kind":"field_change","created_at":"2026-04-29T09:26:13.414719Z","actor":"Andrei","issue_id":"sdplab-tffu.2","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#143"}}
{"id":"int-af6c8aca","kind":"field_change","created_at":"2026-04-29T09:26:14.918456Z","actor":"Andrei","issue_id":"sdplab-tffu.3","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#143"}}
{"id":"int-e21aae28","kind":"field_change","created_at":"2026-04-29T09:26:18.500606Z","actor":"Andrei","issue_id":"sdplab-tffu.4","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"merged via PR#143"}}
{"id":"int-d220cfd5","kind":"field_change","created_at":"2026-04-29T09:26:42.683476Z","actor":"Andrei","issue_id":"sdplab-tffu","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"merged via PR#143, all 4 children closed"}}
{"id":"int-0c7be3e1","kind":"field_change","created_at":"2026-04-29T09:57:19.663242Z","actor":"Andrei","issue_id":"sdplab-5z1p","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"duplicate of sdplab-1ily"}}
{"id":"int-145550c2","kind":"field_change","created_at":"2026-04-29T11:50:02.663081Z","actor":"Andrei","issue_id":"sdplab-1ily","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Merged in PR #145 (cb5470e): Pi resources packaging done"}}
{"id":"int-0ebbc2aa","kind":"field_change","created_at":"2026-04-29T11:50:04.334166Z","actor":"Andrei","issue_id":"sdplab-vd3r","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Merged in PR #145 (cb5470e): selective init preserves existing manifest"}}
{"id":"int-8c54fcaa","kind":"field_change","created_at":"2026-04-29T11:50:05.102199Z","actor":"Andrei","issue_id":"sdplab-zdjr","extra":{"field":"status","new_value":"closed","old_value":"in_progress","reason":"Merged in PR #145 (cb5470e): Pi prompts normalize legacy Claude skill refs"}}
{"id":"int-90b6122a","kind":"field_change","created_at":"2026-04-29T14:56:19.939554Z","actor":"Andrei","issue_id":"sdplab-i8xo","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"false positive: cmd/sdp/cmd_bootstrap.go already passes dryRun into appendGreenfieldArtifacts/appendBrownfieldArtifacts and writeDraftArtifact; TestBootstrapDryRunBrownfieldDoesNotWriteDraftDelta verifies no DRAFT-bootstrap-delta.json is written"}}
Loading
Loading