Skip to content

Add BuildRequires: python3-devel to ensure proper Python metadata is provided in RPM#124

Merged
DrDaveD merged 2 commits intofermitools:masterfrom
duncanmmacleod:rpm-python3-devel
Mar 21, 2025
Merged

Add BuildRequires: python3-devel to ensure proper Python metadata is provided in RPM#124
DrDaveD merged 2 commits intofermitools:masterfrom
duncanmmacleod:rpm-python3-devel

Conversation

@duncanmmacleod
Copy link
Contributor

This PR modifies the RPM spec file for this project to use

BuildRequires: python3-devel

This ensure that proper Python metadata is built and installed with the RPM.

This PR also improves the GitHub Actions workflow that builds and tests the RPMs.

Build a tarball using python-build, then use that to build the SRPM

Use dnf instead of yum throughout
@duncanmmacleod duncanmmacleod force-pushed the rpm-python3-devel branch 4 times, most recently from edae255 to 9b47e7c Compare March 21, 2025 11:39
@duncanmmacleod duncanmmacleod marked this pull request as ready for review March 21, 2025 11:48
Copy link
Collaborator

@DrDaveD DrDaveD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because #122 is merged, this needs to be version 2.2 instead of 2.1-2. Please change that and add a changelog point about removing the root logger.

This ensures that full Python metadata is built and installed with the binary RPM(s)
@duncanmmacleod
Copy link
Contributor Author

Because #122 is merged, this needs to be version 2.2 instead of 2.1-2. Please change that and add a changelog point about removing the root logger.

I have undone the release bump in the RPM to make this change independent of anything else. See #125 for the next step which finalises a 2.2 release (presuming that this PR is merged). I hope that this is what you wanted.

@DrDaveD DrDaveD merged commit bf847bc into fermitools:master Mar 21, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants