Conversation
DrDaveD
requested changes
Mar 21, 2025
Collaborator
DrDaveD
left a comment
DrDaveD
left a comment
There was a problem hiding this comment.
Please rebase on the current master branch
duncanmmacleod
force-pushed
the
prepare-2.2
branch
from
64a9d2c to
255733d
Compare
Contributor
Author
Done. |
DrDaveD
requested changes
Mar 21, 2025
Contributor
Author
That is already updated, see https://github.com/fermitools/htgettoken/pull/125/files#diff-391bd6220c89aaec33adf7f75d5e8beeae2756b1b89fd55b040a2d6567ec02e9. |
DrDaveD
approved these changes
Mar 21, 2025
Collaborator
DrDaveD
left a comment
DrDaveD
left a comment
There was a problem hiding this comment.
Huh. I wonder how I missed that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finalise the 2.2 release, to include #122 and #124.