Skip to content

Remove 50-shard limit on test shard_count - #12

Merged
alexeagle merged 1 commit into
8.6.0-figmafrom
remove-shard-count-limit
Jun 30, 2026
Merged

Remove 50-shard limit on test shard_count#12
alexeagle merged 1 commit into
8.6.0-figmafrom
remove-shard-count-limit

Conversation

@alexeagle

Copy link
Copy Markdown

Summary

  • Remove the hardcoded 50-shard maximum on the shard_count test attribute in RuleConfiguredTargetBuilder.
  • Remove the corresponding testExcessiveShardCount unit test.

Consuming repos can enforce their own policy on shard_count values (e.g. via lint rules or CI checks) without Bazel imposing a global cap.

Test plan

  • bazel test //src/test/java/com/google/devtools/build/lib/analysis:RuleConfiguredTargetTest
  • Verify a test target with shard_count > 50 analyzes successfully

Consuming repos can enforce their own policy on shard_count values.
@alexeagle
alexeagle merged commit 296b683 into 8.6.0-figma Jun 30, 2026
3 checks passed
alexeagle added a commit to alexeagle/buildtools that referenced this pull request Jul 2, 2026
Document timeout, flaky, and shard_count as execution-reflecting attrs;
add shard_count recommender (future), integer flaky semantics from figma/bazel#13,
and attr-policy maxValue for shard_count after figma/bazel#12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants