Remove 50-shard limit on test shard_count - #12
Merged
Conversation
Consuming repos can enforce their own policy on shard_count values.
bzhang-figma
approved these changes
Jun 30, 2026
alexeagle
added a commit
to alexeagle/buildtools
that referenced
this pull request
Jul 2, 2026
Document timeout, flaky, and shard_count as execution-reflecting attrs; add shard_count recommender (future), integer flaky semantics from figma/bazel#13, and attr-policy maxValue for shard_count after figma/bazel#12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shard_counttest attribute inRuleConfiguredTargetBuilder.testExcessiveShardCountunit test.Consuming repos can enforce their own policy on
shard_countvalues (e.g. via lint rules or CI checks) without Bazel imposing a global cap.Test plan
bazel test //src/test/java/com/google/devtools/build/lib/analysis:RuleConfiguredTargetTestshard_count > 50analyzes successfully