Skip to content

Remove 50-shard limit on test shard_count #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeagle merged 1 commit into from
Jun 30, 2026
Merged

Remove 50-shard limit on test shard_count #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/main/java/com/google/devtools/build/lib/analysis/RuleConfiguredTargetBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,11 +451,6 @@ private TestProvider initializeTestProvider(FilesToRunProvider filesToRunProvide
&& ruleContext.getRule().isAttributeValueExplicitlySpecified("shard_count")) {
ruleContext.attributeError("shard_count", "Must not be negative.");
}
if (explicitShardCount > 50) {
ruleContext.attributeError("shard_count",
"Having more than 50 shards is indicative of poor test organization. "
+ "Please reduce the number of shards.");
}
TestActionBuilder testActionBuilder =
new TestActionBuilder(ruleContext)
.setInstrumentedFiles(
Expand Down
10 changes: 0 additions & 10 deletions src/test/java/com/google/devtools/build/lib/analysis/RuleConfiguredTargetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,16 +536,6 @@ public void testNegativeShardCount() throws Exception {
"foo_test(name='bar', srcs=['mockingbird.sh'], shard_count=-1)");
}

@Test
public void testExcessiveShardCount() throws Exception {
checkError(
"foo",
"bar",
"indicative of poor test organization",
"load('//test_defs:foo_test.bzl', 'foo_test')",
"foo_test(name='bar', srcs=['mockingbird.sh'], shard_count=51)");
}

@Test
public void testNonexistingTargetErrorMsg() throws Exception {
checkError("foo", "foo", getErrorNonExistingTarget(
Expand Down
Loading