Raise a warning for unused petsc options in OptionsManager.#21
Merged
connorjward merged 13 commits intomainfrom Nov 3, 2025
Merged
Raise a warning for unused petsc options in OptionsManager.#21connorjward merged 13 commits intomainfrom
OptionsManager.#21connorjward merged 13 commits intomainfrom
Conversation
connorjward
requested changes
Oct 29, 2025
Collaborator
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Same change for the other docstring.
How does this interact with -options_left? I reckon the docstring could include more information.
dham
reviewed
Oct 29, 2025
connorjward
requested changes
Nov 3, 2025
Collaborator
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Very tiny nitpicks. I think this is pretty great now.
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
…keproject/petsctools into JHopeCollins/warn_unused_options
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
connorjward
approved these changes
Nov 3, 2025
connorjward
approved these changes
Nov 3, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifted from firedrakeproject/firedrake#3999.
If
-options_leftis passed on the command line or in theparameterspassed to theOptionsManagerthen warnings will be raised at the end of theOptionsManager's lifetime for any unused options.Closes #20