Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

feature/july-25-connector-update#21

Merged
fivetran-joemarkiewicz merged 5 commits intomainfrom
feature/july-25-connector-update
Jul 14, 2025
Merged

feature/july-25-connector-update#21
fivetran-joemarkiewicz merged 5 commits intomainfrom
feature/july-25-connector-update

Conversation

@fivetran-joemarkiewicz
Copy link
Copy Markdown
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jul 11, 2025

PR Overview

Package version introduced in this PR: v0.4.0

This PR addresses the following Issue/Feature(s): Internal issue to comply with July 2025 connector updates

Summary of changes:

Introduced updates to ensure the Recharge data model is aligned with updates being applied to the Fivetran Recharge connector. Many updates were already addressed; however, the _is_deleted deprecation and _fivetran_deleted additions were not accounted. This update focuses exclusively on those deprecation and additions. I made to sure have the _fivetran_deleted field be included in cases where it's being used, and to not remove the _is_deleted field but clearly identify the deprecation of it. This will allow for a smoother transition for some users. Also, it didn't seem that these fields were entirely 1:1 so I didn't want to perform a coalesce. It felt better to keep them separate and we will remove the _is_deleted in a future breaking change.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
      • Confirmed the updates ran as expected locally and that the new fields persisted into the materialized model. Additionally, confirmed the docs were complete with all relevant fields.
      • Confirmed downstream models are passing and any impacts are accounted for. See PR #31 for dbt_recharge for more details.
    • Testing Instructions: Confirm the change addresses the issue(s)
      • You can verify with seed data that the updates are running as expected.
    • Focus Areas: Complex logic or queries that need extra attention
      • Double check the connector updates to make sure all connector changes are accounted for. Additionally, verify all fields being included in the staging models are accounted for in the get columns macros.

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review July 11, 2025 19:21
Copy link
Copy Markdown
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some preliminary comments on the docs generator!

Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit a10e36d into main Jul 14, 2025
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants