Show appropriate flycam message on touch - #710
Conversation
📝 WalkthroughWalkthroughTouch-specific fly-camera translations were added for eight locales. Fly-mode camera-gizmo instructions now select the touch translation when touch or coarse input is detected, while retaining the existing instruction for other devices. ChangesTouch fly-camera onboarding
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant handleCameraGizmo
participant isTouchDevice
participant LocaleTranslations
handleCameraGizmo->>isTouchDevice: detect touch or coarse input
isTouchDevice-->>handleCameraGizmo: return device classification
handleCameraGizmo->>LocaleTranslations: select touch or standard fly-camera instruction
LocaleTranslations-->>handleCameraGizmo: return localized text
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ui/gizmos.js (1)
2379-2385: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winKeep touch fly controls enabled
_onScreenSource.pause()suspends InputManager updates, so the on-screen buttons no longer move the camera even though the hint tells touch users to use them. Either keep that source active in fly mode or update the copy to the actual available gesture.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/gizmos.js` around lines 2379 - 2385, Remove or avoid pausing flock._onScreenSource when entering fly mode so InputManager continues processing touch controls and the existing fly_camera_instructions_touch hint remains accurate; preserve the gamepad and keyboard fly-mode setup.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locale/pt.js`:
- Around line 1165-1166: Update the fly_camera_instructions_touch locale string
to use European Portuguese terminology consistently: replace the Brazilian terms
for camera, controls, and screen with the locale’s established equivalents,
while preserving the message meaning and emoji.
---
Outside diff comments:
In `@ui/gizmos.js`:
- Around line 2379-2385: Remove or avoid pausing flock._onScreenSource when
entering fly mode so InputManager continues processing touch controls and the
existing fly_camera_instructions_touch hint remains accurate; preserve the
gamepad and keyboard fly-mode setup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f58e6458-8fe2-49aa-a229-1421c3b29b27
📒 Files selected for processing (9)
locale/de.jslocale/en.jslocale/es.jslocale/fr.jslocale/it.jslocale/pl.jslocale/pt.jslocale/sv.jsui/gizmos.js
Summary
Show a more relevant message on mobile when the fly cam is activated
AI usage
Code and translations written by Claude Sonnet 5, supervised by a human.
Summary by CodeRabbit