Skip to content

Run dcm check-unused-code over devtools_shared - #9932

Merged
kenzieschmoll merged 1 commit into
flutter:masterfrom
kenzieschmoll:dcm-devtools-shared
Jul 30, 2026
Merged

Run dcm check-unused-code over devtools_shared#9932
kenzieschmoll merged 1 commit into
flutter:masterfrom
kenzieschmoll:dcm-devtools-shared

Conversation

@kenzieschmoll

Copy link
Copy Markdown
Member

Work towards #9906

@kenzieschmoll
kenzieschmoll requested review from a team and bkonyi as code owners July 30, 2026 17:53

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused analytics-related properties and getters from FlutterStore and adds an analyzer ignore comment to _fileUriPrefix in file_utils.dart. The reviewer noted that the comma-separated explanation in the ignore comment will be misinterpreted by the Dart analyzer as an invalid rule name, and suggested splitting the explanation onto a separate line.

Comment thread packages/devtools_shared/lib/src/utils/file_utils.dart
@kenzieschmoll kenzieschmoll changed the title Run dcm unused-code check over devtools_shared Run dcm check-unused-code over devtools_shared Jul 30, 2026
@kenzieschmoll
kenzieschmoll merged commit d7c7456 into flutter:master Jul 30, 2026
93 of 95 checks passed
@kenzieschmoll
kenzieschmoll deleted the dcm-devtools-shared branch July 30, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants