Skip to content

Run dcm check-unused-code over devtools_shared #9932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 1 commit into from
Jul 30, 2026
Merged

Run dcm check-unused-code over devtools_shared #9932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
- name: Run dcm checks on packages
# TODO(https://github.com/flutter/devtools/issues/9906): run on all DevTools packages.
run: |
dcm check-unused-code packages/devtools_app --exclude-public-api
dcm check-unused-code packages/devtools_app packages/devtools_shared --exclude-public-api

test-packages:
name: ${{ matrix.os }} ${{ matrix.package }} test
Expand Down
6 changes: 0 additions & 6 deletions packages/devtools_shared/lib/src/server/flutter_store.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,10 @@ import 'file_system.dart';
/// Provides access to the local Flutter store (~/.flutter).
class FlutterStore {
static const storeName = '.flutter';
static const firstRunKey = 'firstRun';
static const gaEnabledKey = 'enabled';
static const flutterClientIdKey = 'clientId';

final properties = IOPersistentProperties(storeName);

bool get isFirstRun => properties[firstRunKey] == true;

bool get gaEnabled => properties[gaEnabledKey] == true;

String get flutterClientId =>
(properties[flutterClientIdKey] as String?) ?? '';
}
1 change: 1 addition & 0 deletions packages/devtools_shared/lib/src/utils/file_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'package:dtd/dtd.dart';
import 'package:meta/meta.dart';

// ignore: unused-code, false positive.
const _fileUriPrefix = 'file://';
Comment thread
kenzieschmoll marked this conversation as resolved.

/// Attempts to detect the package root of [fileUriString], which is expected to
Expand Down
Loading