Run dcm check-unused-code on the devtools_extensions package - #9933
Open
kenzieschmoll wants to merge 3 commits into
Open
Run dcm check-unused-code on the devtools_extensions package#9933kenzieschmoll wants to merge 3 commits into
dcm check-unused-code on the devtools_extensions package#9933kenzieschmoll wants to merge 3 commits into
Conversation
kenzieschmoll
changed the title
dcm check-unused-code on the devtools_extensions package
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up unused code in the DevTools extensions simulated environment. Specifically, it removes the unused longPumpDuration constant from the integration tests, removes the unused simController parameter and field from _UriConnectionDisplay and its child widgets, and cleans up unused constants (totalControlsHeight and totalControlsWidth) in the connection UI widgets. I have no feedback to provide.
kenzieschmoll
changed the title
dcm check-unused-code on the devtools_extensions packagedcm check-unused-code on the devtools_extensions package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9906