Skip to content

Run dcm check-unused-code on the devtools_extensions package #9933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenzieschmoll wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Run dcm check-unused-code on the devtools_extensions package #9933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bc2462
Run dcm check-unused-code on the devtools_extensions package
kenzieschmoll Jul 30, 2026
44009bb
Merge branch 'master' of github.com:flutter/devtools into dcm-devtool…
kenzieschmoll Jul 30, 2026
05a45b3
Merge branch 'master' of github.com:flutter/devtools into dcm-devtool…
kenzieschmoll Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
- name: Run dcm checks on packages
# TODO(https://github.com/flutter/devtools/issues/9906): run on all DevTools packages.
run: |
dcm check-unused-code packages/devtools_app packages/devtools_shared --exclude-public-api
dcm check-unused-code packages/devtools_app packages/devtools_extensions packages/devtools_shared --exclude-public-api

test-packages:
name: ${{ matrix.os }} ${{ matrix.package }} test
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_extensions/integration_test/test/simulated_environment_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import 'package:integration_test/integration_test.dart';
// dart run integration_test/run_tests.dart --target=integration_test/test/simulated_environment_test.dart

const safePumpDuration = Duration(seconds: 3);
const longPumpDuration = Duration(seconds: 6);

void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
Expand Down
8 changes: 0 additions & 8 deletions ...s_extensions/lib/src/template/_simulated_devtools_environment/connection_ui/_connect.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ part of '../_simulated_devtools_environment.dart';

class _UriConnectionDisplay extends StatelessWidget {
const _UriConnectionDisplay({
required this.simController,
required this.connected,
required this.connectedLabel,
required this.disconnectedLabel,
Expand All @@ -20,7 +19,6 @@ class _UriConnectionDisplay extends StatelessWidget {
@visibleForTesting
static const totalControlsHeight = 45.0;

final SimulatedDevToolsController simController;
final bool connected;
final String connectedLabel;
final String disconnectedLabel;
Expand All @@ -36,14 +34,12 @@ class _UriConnectionDisplay extends StatelessWidget {
height: totalControlsHeight,
child: connected
? _ConnectedDisplay(
simController: simController,
label: connectedLabel,
onDisconnect: onDisconnect,
currentConnection: currentConnection,
help: help,
)
: _DisconnectedDisplay(
simController: simController,
label: disconnectedLabel,
hint: disconnectedHint,
onConnect: onConnect,
Expand All @@ -55,14 +51,12 @@ class _UriConnectionDisplay extends StatelessWidget {

class _ConnectedDisplay extends StatelessWidget {
const _ConnectedDisplay({
required this.simController,
required this.label,
required this.currentConnection,
required this.onDisconnect,
this.help,
});

final SimulatedDevToolsController simController;
final String label;
final String Function() currentConnection;
final VoidCallback onDisconnect;
Expand Down Expand Up @@ -98,14 +92,12 @@ class _ConnectedDisplay extends StatelessWidget {

class _DisconnectedDisplay extends StatefulWidget {
const _DisconnectedDisplay({
required this.simController,
required this.label,
required this.hint,
required this.onConnect,
this.help,
});

final SimulatedDevToolsController simController;
final String label;
final String hint;
final void Function(String) onConnect;
Expand Down
6 changes: 0 additions & 6 deletions ...tensions/lib/src/template/_simulated_devtools_environment/connection_ui/_dtd_connect.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,13 @@ class DTDConnectionDisplay extends StatelessWidget {
required this.onConnectionChange,
});

@visibleForTesting
static const totalControlsHeight = 45.0;
@visibleForTesting
static const totalControlsWidth = 415.0;

final SimulatedDevToolsController simController;
final bool connected;
final Future<void> Function(String?) onConnectionChange;

@override
Widget build(BuildContext context) {
return _UriConnectionDisplay(
simController: simController,
connected: connected,
connectedLabel: 'Dart Tooling Daemon connection: ',
disconnectedLabel: 'Dart Tooling Daemon Connection',
Expand Down
3 changes: 0 additions & 3 deletions ...s/lib/src/template/_simulated_devtools_environment/connection_ui/_vm_service_connect.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ class VmServiceConnectionDisplay extends StatelessWidget {
required this.connected,
});

@visibleForTesting
static const totalControlsHeight = 45.0;
@visibleForTesting
static const totalControlsWidth = 415.0;

Expand All @@ -23,7 +21,6 @@ class VmServiceConnectionDisplay extends StatelessWidget {
@override
Widget build(BuildContext context) {
return _UriConnectionDisplay(
simController: simController,
connected: connected,
connectedLabel: 'Debugging: ',
disconnectedLabel: 'Dart VM Service Connection',
Expand Down
Loading