Skip to content

Fixes #1564 #1565

Open
PeterRobots wants to merge 2 commits into
foobnix:masterfrom
PeterRobots:fix-brightness-edge-scroll
Open

Fixes #1564 #1565
PeterRobots wants to merge 2 commits into
foobnix:masterfrom
PeterRobots:fix-brightness-edge-scroll

Conversation

@PeterRobots

Copy link
Copy Markdown

Fixes Moved the brightness helper check on scroll to above any scroll value changes.

@PeterRobots

Copy link
Copy Markdown
Author

After testing I still need to fix the brightness jumping, but scroll jumping is fixed.

@PeterRobots

PeterRobots commented Jul 6, 2026

Copy link
Copy Markdown
Author

After testing I still need to fix the brightness jumping, but scroll jumping is fixed.

Fixed with Commit: 5a4d1dc

  • scroll brightness calculation to just use *100/MIN
  • First activation of scroll brightness just posts current value
  • action_down now sets currentPercent to actual current brightness percentage using updateCurrentValue()

Scroll brightness and scroll mode are now much more independent. Brightness no longer jumps values on successive uses or scrolling pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant