Skip to content

Fixes #1564 #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterRobots wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #1564 #1565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8757ae
Moved the brightness helper check on scroll to above any scroll value…
PeterRobots Jul 5, 2026
5a4d1dc
get current brightness on action_down and consistent scroll brightnes…
PeterRobots Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions app/src/main/java/com/foobnix/pdf/info/view/BrightnessHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ public void onActoinDown(float x, float y) {
this.x = x;
this.y = y;
isMovementStart = false;
currentPercent = getMinMaxValue(currentPercent + lastPercent);
updateCurrentValue();
}

public void onActionUp() {
Expand All @@ -400,15 +400,15 @@ public boolean onActionMove(final MotionEvent event) {
float dx = Math.abs(x - event.getX());

if ((isMovementStart || dy > Dips.DP_25) && event.getPointerCount() == 1 && x < BRIGHTNESS_WIDTH && dy > dx) {
isMovementStart = true;

if (y < Dips.screenHeight() / 3 || y > Dips.screenHeight() - Dips.screenHeight() / 3) {
lastPercent = (int) (yDiff * 100 / MIN);
float plus;
if (!isMovementStart) { // On first call update y and enable isMovementStart and do not change brightness.
this.y = event.getY();
plus = currentPercent;
} else {
lastPercent = (int) (yDiff * 100 / MAX);
lastPercent = (int) (yDiff * 100 / MIN);
plus = getMinMaxValue(lastPercent + currentPercent);
}

float plus = getMinMaxValue(lastPercent + currentPercent);
isMovementStart = true;
EventBus.getDefault().post(new MessegeBrightness((int) plus));
}
return isMovementStart;
Expand Down
8 changes: 3 additions & 5 deletions app/src/main/java/com/foobnix/sys/AdvGuestureDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,12 @@ public boolean onScroll(final MotionEvent e1, final MotionEvent e2, final float
if (docCtrl.checkReadingTimer()) {
return true;
}

final float x = distanceX, y = distanceY;
d1 += x;
d2 += y;

if (brightnessHelper.onActionMove(e2)) {
return true;
}
final float x = distanceX, y = distanceY;
d1 += x;
d2 += y;

long delta = System.currentTimeMillis() - t;
long value = AppSP.get().isLocked ? 5 : 10;
Expand Down