Closed
Conversation
There was a problem hiding this comment.
According to Elvis:
Invalid macro name schema_loader_fun on line 48. Use UPPER_CASE.
Closed
Member
Author
|
closing in favour of #5 |
galambl
pushed a commit
to galambl/jesse
that referenced
this pull request
Jul 16, 2021
…-schemas-for-all-types-of-messages to master-otpbank * commit 'e8d350dd2c2ef0b4c190238c0e3194791b70ee3a': RTA-730-create-schemas-for-all-types-of-messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of klarna/jesse#34 by @jamesaimonetti
First pass at getting $ref support.
Punting on absolute URIs (or $ref value not starting with '#') by allowing the caller to pass a schema_loader_fun function that will return the schema JSON object, if found.
Appreciate any feedback!