fix: correct status codes for add and delete group member#183
Open
senutpal wants to merge 1 commit into
Open
Conversation
fossology.add_group_member and fossology.delete_group_member incorrectly checked for a 200 status code on success. the api actually returns 201 and 202, causing valid operations to fail. this updates the expected codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #179
this fixes an issue where add_group_member and delete_group_member were throwing errors on success. the api returns 201 and 202 instead of 200, so this just updates the checks to match what the api actually sends back.