Skip to content

fix: correct status codes for add and delete group member #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
senutpal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct status codes for add and delete group member #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fossology/groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def add_group_member(
response = self.session.post(
f"{self.api}/groups/{group_id}/user/{user_id}", json=data
)
if response.status_code == 200:
if response.status_code == 201:
logger.info(f"User {user_id} has been added to group {group_id}.")
elif response.status_code == 400:
logger.info(f"User {user_id} is already a member of group {group_id}.")
Expand All @@ -140,7 +140,7 @@ def delete_group_member(self, group_id: int, user_id: int):
:raises FossologyApiError: if the REST call failed
"""
response = self.session.delete(f"{self.api}/groups/{group_id}/user/{user_id}")
if response.status_code == 200:
if response.status_code == 202:
logger.info(f"User {user_id} will be removed from group {group_id}.")
elif response.status_code == 400:
description = f"Validation error while removing member {user_id} from group {group_id}."
Expand Down