Skip to content

feature: EST Rotate - Inclusive E/KU Check; #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Scylin232 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

feature: EST Rotate - Inclusive E/KU Check; #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions internal/rotate_est.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,18 +189,20 @@ func verifyNewCert(curCert, newCert *x509.Certificate) error {
if !bytes.Equal(curCert.RawSubject, newCert.RawSubject) {

@doanac doanac Aug 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github does not allow you to comment on commit messages. However, the commit needs a couple things:

  • A Signed-off-by
  • A description of the change. Your PR header is good - you could just use that content in the commit message

Our security engineer is on holiday this week. When he gets back, we'll have him take a close look.

@Scylin232 Scylin232 Aug 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon my commit etiquette. Fixed! :)
Let's wait for the security engineer then, thanks!

return errors.New("New cert's subject does not match current cert's")
}
foundDigitalSig := false

foundDigitalSig := newCert.KeyUsage & x509.KeyUsageDigitalSignature != 0
foundClientAuth := false
for _, ext := range newCert.Extensions {
if !foundDigitalSig && ext.Id.Equal(oidKeyUsage) {
foundDigitalSig = bytes.Equal(ext.Value, asn1DigitalSignature)
} else if !foundClientAuth && ext.Id.Equal(oidExtendedKeyUsage) {
foundClientAuth = bytes.Equal(ext.Value, asn1TlsWebClientAuth)

for _, eku := range newCert.ExtKeyUsage {
if eku == x509.ExtKeyUsageClientAuth {
foundClientAuth = true
break
}
}

if foundDigitalSig && foundClientAuth {
return nil
}

return errors.New("Missing required extensions for Digital Signature and/or TLS Web Client Authentication")
}