Conversation
Introduces a frozen private ``_RerankerRegistration`` dataclass bundling the nine non-session inputs both the multipart and by-reference reranker-model endpoints feed into ``_register_model``. ``_register_model`` signature collapses 10 args → 2 (session, reg). Both call-sites build the registration inline. Sizes: - reranker_models.py: +20 LOC (dataclass) - 16 LOC (kwargs at call-sites) ≈ +4 LOC net - Smell baseline: 78 -> 77 (`_register_model` retired from params>6: 23 → 22) Helper is private (underscore prefix) — only the two router endpoints in this file use it. Tests touch the endpoints by HTTP, never the helper directly, so no test churn. Local-first 5 verde (ruff + flake8 + pytest 1163 + check_smells).
4 tasks
frapercan
added a commit
that referenced
this pull request
May 8, 2026
## Acceptance criteria (master plan §24 Fase 1 — T-CONTEXTS partial) Fourth incremental Parameter Object slice. Tackles the last remaining 16-arg offender in core (after #73, #75, #77). ## Changes - ``protea/core/parquet_export.py``: - New ``@dataclass(frozen=True) ParquetExportContext`` bundling 15 per-call inputs grouped into 3 sections (source shards, dataset identity, publishing). - ``export_reranker_parquets`` signature collapses 16 args → 1 (``ctx``). - Body destructures the context once at the top so the rest of the implementation stays diff-minimal. - ``protea/core/training_dump_helpers.py``: production caller updated. - ``tests/test_parquet_export_boundary.py``: only test that invokes it updated. ## Smell budget 77 → 75 offenders. **params>6: 22 → 20** (`export_reranker_parquets` retired plus 1 knock-on improvement as the dataclass centralises type annotations). ## Test plan - [x] `poetry run ruff check protea scripts` - [x] `poetry run flake8 protea/` - [x] `poetry run pytest tests/ --ignore=tests/test_jobs_pg.py` (1163 passed, 11 skipped) - [x] `poetry run python scripts/check_smells.py` (75 known, none new) ## T-CONTEXTS progress (4 slices total) - #73: KnnEnrichmentContext — enrich_v6_features 9 → 4 args - #75: CafaEvalRunContext — evaluate_all_settings 18 → 3 args - #77: _RerankerRegistration — _register_model 10 → 2 args - this PR: ParquetExportContext — export_reranker_parquets 16 → 1 arg Combined: 53 → 10 args across the four entry points; baseline params>6: 24 → 20 (cumulative drop -4).
4 tasks
frapercan
added a commit
that referenced
this pull request
May 8, 2026
## Acceptance criteria (master plan §24 Fase 1 — T-CONTEXTS partial) Fifth incremental Parameter Object slice. Tackles the remaining 16-arg offender in core training pipeline. ## Changes - `protea/core/training_dump_helpers.py`: - New ``KnnTransferContext`` frozen dataclass bundling the 12 per-call data inputs (queries, references, ontology maps, optional enrichment helpers). - ``_knn_transfer_and_label`` signature collapses 16 args → 5 (``session``, ``p``, ``ctx``, plus existing ``sequence_context`` / ``stream_output``). - Two production call sites updated (train branch + test-stream branch). - `tests/test_knn_streaming_smoke.py`: shared test runner updated. ## Smell budget 77 → 75 offenders. **params>6: 22 → 20** (`_knn_transfer_and_label` retired plus 1 knock-on). ## Test plan - [x] `poetry run ruff check protea scripts` - [x] `poetry run flake8 protea/` - [x] `poetry run pytest tests/ --ignore=tests/test_jobs_pg.py` (1163 passed, 11 skipped) - [x] `poetry run python scripts/check_smells.py` (75 known, none new) ## T-CONTEXTS progress (5 slices total, 4 in flight pending CI) - #73 KnnEnrichmentContext — enrich_v6_features 9 → 4 args - #75 CafaEvalRunContext — evaluate_all_settings 18 → 3 args - #77 _RerankerRegistration — _register_model 10 → 2 args - #78 ParquetExportContext — export_reranker_parquets 16 → 1 arg - this PR KnnTransferContext — _knn_transfer_and_label 16 → 5 args Combined: 69 args → 15 across the 5 entry points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria (master plan §24 Fase 1 — T-CONTEXTS partial)
Third incremental Parameter Object slice (after #73 KnnEnrichmentContext, #75 CafaEvalRunContext).
Changes
_RerankerRegistrationfrozen dataclass bundling the nine non-session inputs both register endpoints (multipart + by-reference) feed into_register_model._register_modelsignature collapses 10 args → 2 (session, reg).Smell budget
78 → 77 offenders.
_register_modelretired from params>6 (23 → 22).Test plan
poetry run ruff check protea scriptspoetry run flake8 protea/poetry run pytest tests/ --ignore=tests/test_jobs_pg.py(1163 passed, 11 skipped)poetry run python scripts/check_smells.py(77 known, none new)