Skip to content
This repository was archived by the owner on Jun 25, 2026. It is now read-only.

fix(screener): correct icon, restrict move/add, batch triage requests#616

Merged
krantheman merged 3 commits into
frappe:developfrom
krantheman:fix/screener-bugs
Jun 25, 2026
Merged

fix(screener): correct icon, restrict move/add, batch triage requests#616
krantheman merged 3 commits into
frappe:developfrom
krantheman:fix/screener-bugs

Conversation

@krantheman

Copy link
Copy Markdown
Member

Fixes a few Screener bugs:

  • Icon: the Screener's eye icon is now authoritative in getIcon, so a stray Mailbox Settings icon can't make it render as a generic folder.
  • Move/Add: the Screener (a system folder) is excluded from the move-to / add-to target lists and from the Folders management list.
  • Batching: Block/Allow now batch into one request per burst, so screening senders in quick succession no longer fires concurrent automation-sieve rebuilds that race on the shared script (CannotChangeConstantError).

Also renames SCREENING_MAILBOX_NAMESCREENER_MAILBOX_NAME and mailboxIds.screening.screener for naming consistency.

🤖 Generated with Claude Code

- getIcon: the Screener's 'eye' icon is authoritative, so a stray Mailbox
  Settings icon can't make it render as a generic folder
- exclude the Screener (a system folder) from move/add target lists and from
  the Folders management list
- batch Block/Allow so rapid triage no longer fires concurrent sieve rebuilds
  that race on the shared automation script (CannotChangeConstantError)
- rename SCREENING_MAILBOX_NAME -> SCREENER_MAILBOX_NAME and
  mailboxIds.screening -> .screener for naming consistency

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The latest batching path submits allow and screen-out actions independently.
  • The renamed Screener identifiers are used consistently in the inspected changed files.

Important Files Changed

Filename Overview
frontend/src/pages/ScreenerView.vue Adds delayed batching for Screener allow and screen-out actions, with independent handling for each action type.
frontend/src/stores/user.ts Renames the derived Screener mailbox id key and maps it from the Screener mailbox name.
frontend/src/components/Settings/FolderSettings.vue Filters the Screener out of the folder management list.
frontend/src/utils/index.ts Makes the Screener eye icon take priority over stored custom folder icons.
mail/api/mail.py Updates backend screening mailbox lookups to use the renamed Screener constant.
mail/api/sieve.py Renames the Screener mailbox constant and applies it to mailbox creation and folder-path lookup.

Reviews (3): Last reviewed commit: "style(sieve): apply ruff-format to backf..." | Re-trigger Greptile

Comment thread frontend/src/pages/ScreenerView.vue Outdated
Comment thread frontend/src/stores/user.ts
Submit the allow and screen-out requests independently so a failure in one
doesn't skip the other (a burst can mix both across different senders, all
already optimistically removed). Addresses review on frappe#616.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
krantheman added a commit to krantheman/mail_client that referenced this pull request Jun 25, 2026
Submit the allow and screen-out requests independently so a failure in one
doesn't skip the other (a burst can mix both across different senders, all
already optimistically removed). Addresses review on frappe#616.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Satisfies the Frappe Linter (ruff-format --all-files) on frappe#616.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
krantheman added a commit that referenced this pull request Jun 25, 2026
fix(screener): correct icon, restrict move/add, batch triage requests (backport #616)
@krantheman krantheman merged commit b957dac into frappe:develop Jun 25, 2026
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant