chore: 未完成エントリポイントの棚卸し（main_cli.py以外） - #114
Merged
Merged
Conversation
app.py:73(nexus CLI)の戻り値契約ズレバグ修正(PR #106)を機に、 他のエントリポイントに同種バグが眠っていないか全経路を監査。 - nexus CLIの他コマンド・unified_gradio_ui.py(Dynamic Runタブ含む)・ bootstrap_apikey.pyは契約ズレなしと確認 - src/main_ui.py を削除: 2025-01「4.5 UI統合」でunified_gradio_ui.pyに 統合された後の抜け殻。フォールバック先モジュールはdb0424d8で no imports found確認済みで既に削除済みのため到達不能 - src/dev_tools/test_manager.py を削除: 存在しないモジュールをimportし 確実にImportErrorで落ちる・他から一切参照なし - tests/ui/test_main_ui.py・test_main_ui_unit.py を削除: main_ui.py専用のカバレッジ稼ぎ用テスト（実体テストなし） テスト: tests/ui,tests/tools 90 passed / フルスイート4904 passed, 1 failed(既存・MiniMaxモデル名の無関係な古いテスト) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
STIT Pipeline Result ✅Branch: All STIT checks have completed. Check the workflow run for details. |
Phase3 Coverage (graph_builder / unified_analyzer / test_generator / tree_sitter_checker)
|
STIT Pipeline Result ✅Branch: All STIT checks have completed. Check the workflow run for details. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.py:73(nexus CLI)の戻り値契約ズレバグ修正(PR fix: nexus CLI run が OrchestratorContext を dict 扱いして必ず AttributeError で落ちる問題を修正 #106)を機に、main_cli.py以外の全エントリポイントを棚卸し（バックログ.md P2タスク）nexusCLIの他コマンド・unified_gradio_ui.pyのDynamic Runタブ含む・bootstrap_apikey.py）は同種の戻り値契約ズレなしと確認src/main_ui.pyを削除 — 2025-01「4.5 UI統合」でunified_gradio_ui.pyに統合された後の抜け殻。フォールバック先モジュール（app_ui.py等）はdb0424d8で no imports found 確認済みで既に削除済みのため到達不能src/dev_tools/test_manager.pyを削除 — 存在しないモジュール（code_generator等）をimportし確実にImportErrorで落ちる、どこからも参照なしtests/ui/test_main_ui.py/test_main_ui_unit.pyを削除 —main_ui.py専用のカバレッジ稼ぎ用テスト（実体テストなし）で道連れ削除Test plan
tests/ui/,tests/tools/— 90 passed, 0 failedtests/— 4904 passed, 1 failed（既存・MiniMax-M2.7→MiniMax-M3のモデル名不一致・本PRと無関係）, 204 skipped🤖 Generated with Claude Code