fix(llm): MiniMaxモデル名表記をMiniMax-M3(PascalCase)に統一 - #115
Merged
Conversation
- llm_profiles.py: minimax_default/analytical のmodelをminimax-m3→MiniMax-M3 - test_generator.py: _call_minimaxデフォルトをMiniMax-M2.7(旧)→MiniMax-M3 - 上記テスト追従 + test_call_minimax_sends_correct_payload をMINIMAX_MODEL env明示セットで.env流入防御 - 実API(.env MINIMAX_MODEL=MiniMax-M3)と整合・小文字送信によるAPI弾きリスク解消 - 検証: LLM系681 passed / フル4905 passed・0 failed(従来1 failed→ゼロ化) Co-Authored-By: Claude <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
STIT Pipeline Result ✅Branch: All STIT checks have completed. Check the workflow run for details. |
Phase3 Coverage (graph_builder / unified_analyzer / test_generator / tree_sitter_checker)
|
STIT Pipeline Result ✅Branch: All STIT checks have completed. Check the workflow run for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MiniMaxモデル名の表記揺れ(
minimax-m3小文字 /MiniMax-M3PascalCase)をMiniMax-M3に統一。llm_profiles.py: PROFILE_REGISTRY の minimax_default/analytical をminimax-m3→MiniMax-M3test_generator.py:_call_minimaxデフォルトをMiniMax-M2.7(旧モデル)→MiniMax-M3test_call_minimax_sends_correct_payloadはMINIMAX_MODELenv を明示セットして.env流入を防御(従来は env 未隔離でフルスイート時のみ1件FAIL)背景
実API(
.envのMINIMAX_MODEL=MiniMax-M3)と整合しない小文字表記が残存。_call_minimaxが env 未設定時に小文字を送り実APIで弾かれるリスクがあった(PR #114 の test plan にも1 failed(MiniMax-M2.7→MiniMax-M3不一致)と記載)。Test plan
tests/llm/+ test_generator — 681 passed / 0 failedtests/— 4905 passed / 0 failed(従来 4904 passed, 1 failed → 失敗ゼロ化)🤖 Generated with Claude Code