Remove 'Stack trace' from break loop messages#6429
Open
fingolfin wants to merge 1 commit into
Open
Conversation
ThomasBreuer
reviewed
Jun 6, 2026
Contributor
ThomasBreuer
left a comment
There was a problem hiding this comment.
I thought the format was inspired by that of the error messages in Julia, where the specific message text is followed by a line Stacktrace: (not Stack trace:) and then the description of the call stack, with numbers for the levels.
I have no preference for keeping the line in question or leaving it out.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6429 +/- ##
=======================================
Coverage 78.87% 78.87%
=======================================
Files 685 685
Lines 293543 293541 -2
Branches 8679 8682 +3
=======================================
+ Hits 231519 231520 +1
+ Misses 60215 60212 -3
Partials 1809 1809 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added this in PR #6257 but now am not so sure anymore I like it, and the way it is inserted. See this comment on PR #6416.