Skip to content

Remove 'Stack trace' from break loop messages#6429

Open
fingolfin wants to merge 1 commit into
masterfrom
mh/no-stacktrace-in-breakloop-msg
Open

Remove 'Stack trace' from break loop messages#6429
fingolfin wants to merge 1 commit into
masterfrom
mh/no-stacktrace-in-breakloop-msg

Conversation

@fingolfin
Copy link
Copy Markdown
Member

I've added this in PR #6257 but now am not so sure anymore I like it, and the way it is inserted. See this comment on PR #6416.

@fingolfin fingolfin added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: error handling labels Jun 6, 2026
Copy link
Copy Markdown
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the format was inspired by that of the error messages in Julia, where the specific message text is followed by a line Stacktrace: (not Stack trace:) and then the description of the call stack, with numbers for the levels.

I have no preference for keeping the line in question or leaving it out.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.87%. Comparing base (9196a1f) to head (a51536f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6429   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files         685      685           
  Lines      293543   293541    -2     
  Branches     8679     8682    +3     
=======================================
+ Hits       231519   231520    +1     
+ Misses      60215    60212    -3     
  Partials     1809     1809           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: error handling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants