Skip to content

RFC: Remove 'Stack trace' from break loop messages (???) #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fingolfin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC: Remove 'Stack trace' from break loop messages (???) #6429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/ref/debug.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ error as in the following example occurs and a break loop is entered:
gap> IsNormal(2,2);
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `IsNormal' on 2 arguments
Stack trace:
Copy link
Copy Markdown
Member Author

@fingolfin fingolfin Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example of Stack trace: with an "empty" stack trace; this is what first lead to me questioning whether this line is helpful or not...

Copy link
Copy Markdown
Member Author

@fingolfin fingolfin Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also addressed by PR #6432

called from read-eval loop at *stdin*:1
type 'quit;' to quit to outer loop
brk>
Expand Down
2 changes: 0 additions & 2 deletions doc/ref/language.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,6 @@ gap> xx := 15;
gap> MakeReadOnlyGlobal("xx");
gap> xx := 16;
Error, Variable: 'xx' is read only
Stack trace:
not in any function at *stdin*:3
type 'quit;' to quit to outer loop
brk> quit;
Expand Down Expand Up @@ -1562,7 +1561,6 @@ gap> f2:= function( x ) return f1( x ); end;;
gap> f2( 4 );
value: 4
Error, Function Calls: <func> must return a value
Stack trace:
*[1] f1( x )
@ *stdin*:2
<function "f2">( <arguments> )
Expand Down
3 changes: 0 additions & 3 deletions doc/ref/mloop.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,6 @@ indicate that you are in a break loop.
<Log><![CDATA[
gap> 1/0;
Error, Rational operations: <divisor> must not be zero
Stack trace:
not in any function at *stdin*:2
type 'quit;' to quit to outer loop
]]></Log>
Expand All @@ -488,7 +487,6 @@ If errors occur within a break loop &GAP; enters another break loop at a
<Log><![CDATA[
brk> 1/0;
Error, Rational operations: <divisor> must not be zero
Stack trace:
not in any function at *errin*:1
type 'quit;' to quit to outer loop
brk_2>
Expand Down Expand Up @@ -898,7 +896,6 @@ gap> fun := function() local x; x := 3; bar(); end;
function( ) ... end
gap> fun();
Error, !!
Stack trace:
*[1] Error( "!!\n" );
@ *stdin*:4
[2] bar( );
Expand Down
1 change: 0 additions & 1 deletion doc/ref/types.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,6 @@ for an object.
<Log><![CDATA[
gap> Setter( prop )( Rationals, false );
Error, You cannot set an "and-filter" except to true
Stack trace:
not in any function at *stdin*:8
type 'quit;' to quit to outer loop
brk>
Expand Down
1 change: 0 additions & 1 deletion doc/tut/lists.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,6 @@ gap> list[3][5] := 'w';; list; copy;
[ 1, 2, "three", [ 4 ] ]
gap> copy[3][5] := 'w';
Error, List Assignment: <list> must be a mutable list
Stack trace:
not in any function at *stdin*:3
type 'quit;' to quit to outer loop
brk> quit;
Expand Down
3 changes: 0 additions & 3 deletions lib/error.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,6 @@ BIND_GLOBAL("ErrorInner", function(options, earlyMessage)

printAutomaticTraceback := function()
if IsBound(OnBreak) and IsFunction(OnBreak) then
if OnBreak = Where or OnBreak = WhereWithVars then
PrintTo(ERROR_OUTPUT, "Stack trace:\n");
fi;
Comment on lines -304 to -306
Copy link
Copy Markdown
Member Author

@fingolfin fingolfin Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note also this implementation is a bit wonky. Perhaps Stack trace: should always be printed in Where?

Copy link
Copy Markdown
Member Author

@fingolfin fingolfin Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah and this also breaks when certain packages are loaded: e.g. for me Browse is autoloaded, and therefore I never see the Stack trace::

gap> Display(OnBreak);
# /Users/mhorn/Projekte/GAP/gap/pkg/browse/lib/ncurses.gi:437
function (  )
    if not NCurses.isendwin(  ) then
        NCurses.endwin(  );
    fi;
    OnBreakSavedByBrowse(  );
    return;
end

Copy link
Copy Markdown
Member Author

@fingolfin fingolfin Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR #6432 for an attempt to clean this up.

OnBreak();
fi;
end;
Expand Down
1 change: 0 additions & 1 deletion lib/grpfp.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ fi;
## Group([ b ])
## gap> Index( f, u );
## Error, the coset enumeration has defined more than 4096000 cosets
## Stack trace:
## *[1] Error( "the coset enumeration has defined more ", "than ", limit, " cosets\n" );
## @ GAPROOT/lib/grpfp.gi:1230
## [2] TCENUM.CosetTableFromGensAndRels( fgens, grels, fsgens )
Expand Down
3 changes: 0 additions & 3 deletions tst/testspecial/64bit/low-mem-list-types.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
gap> ListWithIdenticalEntries(2^50, 'a');
Error, Cannot allocate 1125899906842633 bytes: cannot extend the workspace any more!!
Stack trace:
not in any function at *stdin*:2
type 'quit;' to quit to outer loop
brk> quit;
gap> ListWithIdenticalEntries(2^50, true);
Error, Cannot allocate 140737488355336 bytes: cannot extend the workspace any more!!
Stack trace:
not in any function at *stdin*:2
type 'quit;' to quit to outer loop
brk> quit;
gap> ListWithIdenticalEntries(2^50, 2);
Error, Cannot allocate 9007199254741000 bytes: cannot extend the workspace any more!!
Stack trace:
not in any function at *stdin*:2
type 'quit;' to quit to outer loop
brk> quit;
Expand Down
2 changes: 0 additions & 2 deletions tst/testspecial/64bit/low-mem-plist-1.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@ gap> l := [];
[ ]
gap> l[2^50] := 1;
Error, Cannot allocate 9007199254741000 bytes: cannot extend the workspace any more!!!!
Stack trace:
not in any function at *stdin*:3
type 'quit;' to quit to outer loop
brk> quit;
gap> l[2^50] := 2;
Error, Cannot allocate 9007199254741000 bytes: cannot extend the workspace any more!!!!
Stack trace:
not in any function at *stdin*:3
type 'quit;' to quit to outer loop
brk> quit;
Expand Down
2 changes: 0 additions & 2 deletions tst/testspecial/64bit/low-mem-plist-2.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
gap> EmptyPlist(2^50);
Error, Cannot allocate 9007199254741000 bytes: cannot extend the workspace any more!!
Stack trace:
not in any function at *stdin*:2
type 'quit;' to quit to outer loop
brk> quit;
gap> EmptyPlist(2^50);
Error, Cannot allocate 9007199254741000 bytes: cannot extend the workspace any more!!
Stack trace:
not in any function at *stdin*:2
type 'quit;' to quit to outer loop
brk> quit;
Expand Down
16 changes: 0 additions & 16 deletions tst/testspecial/backtrace.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ function( ) ... end
gap> f();
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `[]:=' on 3 arguments
Stack trace:
*[1] l[[ 1 .. 3 ]] := 1;
@ *stdin*:11
<function "f">( <arguments> )
Expand All @@ -38,7 +37,6 @@ gap> ###########################################################################
gap> f:=function() if true = 1/0 then return 1; fi; return 2; end;;
gap> f();
Error, Rational operations: <divisor> must not be zero
Stack trace:
*[1] 1 / 0
@ *stdin*:15
<function "f">( <arguments> )
Expand All @@ -62,7 +60,6 @@ gap> ###########################################################################
gap> f:=function() local x; if x then return 1; fi; return 2; end;;
gap> f();
Error, Variable: 'x' must have an assigned value
Stack trace:
*[1] if x then
return 1;
fi;
Expand Down Expand Up @@ -93,7 +90,6 @@ gap> ###########################################################################
gap> f:=function() if 1 then return 1; fi; return 2; end;;
gap> f();
Error, <expr> must be 'true' or 'false' (not the integer 1)
Stack trace:
*[1] if 1 then
return 1;
fi;
Expand Down Expand Up @@ -123,7 +119,6 @@ gap> ###########################################################################
gap> f:=function() if 1 < 0 then return 1; elif 1 then return 2; fi; return 3; end;;
gap> f();
Error, <expr> must be 'true' or 'false' (not the integer 1)
Stack trace:
*[1] if 1 < 0 then
return 1;
elif 1 then
Expand Down Expand Up @@ -159,7 +154,6 @@ gap> ###########################################################################
gap> f:=function() while 1 do return 1; od; return 2; end;;
gap> f();
Error, <expr> must be 'true' or 'false' (not the integer 1)
Stack trace:
*[1] while 1 do
return 1;
od;
Expand Down Expand Up @@ -189,7 +183,6 @@ gap> ###########################################################################
gap> f:=function() local i; for i in 1 do return 1; od; return 2; end;;
gap> f();
Error, You cannot loop over the integer 1 did you mean the range [1..1]
Stack trace:
*[1] Error( "You cannot loop over the integer ", n, " did you mean the range [1..", n, "]" );
@ GAPROOT/lib/integer.gi:LINE
[2] for i in 1 do
Expand Down Expand Up @@ -231,7 +224,6 @@ gap> f:=function() local i; for i in true do return 1; od; return 2; end;;
gap> f();
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Iterator' on 1 arguments
Stack trace:
*[1] for i in true do
return 1;
od;
Expand Down Expand Up @@ -262,7 +254,6 @@ gap> f:=function(x) local i,j; for i in true do return 1; od; return 2; end;;
gap> f([1,2,3]);
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Iterator' on 1 arguments
Stack trace:
*[1] for i in true do
return 1;
od;
Expand Down Expand Up @@ -295,7 +286,6 @@ gap> f:=function(x) local i,j; Unbind(x); for i in true do return 1; od; return
gap> f([1,2,3]);
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Iterator' on 1 arguments
Stack trace:
*[1] for i in true do
return 1;
od;
Expand Down Expand Up @@ -328,7 +318,6 @@ gap> f:=function(x) local i,j; Unbind(x); j := 4; for i in true do return 1; od;
gap> f([1,2,3]);
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Iterator' on 1 arguments
Stack trace:
*[1] for i in true do
return 1;
od;
Expand Down Expand Up @@ -360,7 +349,6 @@ gap>
gap> f:=function() local x; repeat x:=1; until 1; return 2; end;;
gap> f();
Error, <expr> must be 'true' or 'false' (not the integer 1)
Stack trace:
*[1] repeat
x := 1;
until 1;
Expand Down Expand Up @@ -391,7 +379,6 @@ gap> ###########################################################################
gap> f:=function() local x; Assert(0, 1); return 2; end;;
gap> f();
Error, Assert: <cond> must be 'true' or 'false' (not the integer 1)
Stack trace:
*[1] Assert( 0, 1 );
@ *stdin*:44
<function "f">( <arguments> )
Expand All @@ -416,7 +403,6 @@ gap> ###########################################################################
gap> f:=function() local x; Assert(0, 1, "hello"); return 2; end;;
gap> f();
Error, Assert: <cond> must be 'true' or 'false' (not the integer 1)
Stack trace:
*[1] Assert( 0, 1, "hello" );
@ *stdin*:47
<function "f">( <arguments> )
Expand Down Expand Up @@ -446,7 +432,6 @@ gap> InstallMethod( \[\,\], [ IsMatrixOrMatrixObj, IsPosInt, IsPosInt ],
gap> l := [[1]];; f := {} -> l[2,1];;
gap> f();
Error, List Element: <list>[2] must have an assigned value
Stack trace:
*[1] return m[i][j];
@ GAPROOT/lib/matrix.gi:LINE
[2] ELM_LIST( m, row, col )
Expand Down Expand Up @@ -494,7 +479,6 @@ gap> ## Verify issue #1373 is fixed
gap> ##
gap> InstallMethod( Matrix, [IsFilter, IsSemiring, IsMatrixObj], {a,b,c} -> fail );
Error, FLAGS_FILTER: <oper> must be an operation (not a function)
Stack trace:
*[1] <<compiled GAP function "INSTALL_METHOD">>
@ GAPROOT/lib/oper1.g:LINE
[2] <<compiled GAP function "InstallMethod">>
Expand Down
3 changes: 0 additions & 3 deletions tst/testspecial/backtrace2.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ gap> test:= function( n )
> end;;
gap> test( 1 );
Error, !
Stack trace:
*[1] Error( "!\n" );
@ *stdin*:24
[2] test( n + 1 );
Expand Down Expand Up @@ -121,7 +120,6 @@ gap> test:= function( n )
> end;;
gap> test( 1 );
Error, Rational operations: <divisor> must not be zero
Stack trace:
*[1] 1 / 0
@ *stdin*:35
[2] test( n + 1 );
Expand Down Expand Up @@ -217,7 +215,6 @@ gap> test:= function( n )
gap> test( 1 );
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `IsCommutative' on 1 arguments
Stack trace:
*[1] IsAbelian( 1 )
@ *stdin*:47
[2] test( n + 1 );
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/bad-add.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ function( ) ... end
gap> f();
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `+' on 2 arguments
Stack trace:
*[1] 1 + "abc"
@ *stdin*:3
<function "f">( <arguments> )
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/bad-array-double-1.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ function( ) ... end
gap> f();
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `[,]' on 3 arguments
Stack trace:
*[1] return "abc"[1, 1];
@ *stdin*:3
<function "f">( <arguments> )
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/bad-array-int-0.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ function( ) ... end
gap> f();
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `[]' on 2 arguments
Stack trace:
*[1] return l[0];
@ *stdin*:5
<function "f">( <arguments> )
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/bad-array-int-1.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ gap> f := function()
function( ) ... end
gap> f();
Error, List Element: <list> must be a list (not the integer 1)
Stack trace:
*[1] return 1[1];
@ *stdin*:3
<function "f">( <arguments> )
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/bad-array-string.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ function( ) ... end
gap> f();
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `[]' on 2 arguments
Stack trace:
*[1] return 1["abc"];
@ *stdin*:3
<function "f">( <arguments> )
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/bad-array-undef-0.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ gap> f := function()
function( ) ... end
gap> f();
Error, Variable: 'l' must have an assigned value
Stack trace:
*[1] return l[1];
@ *stdin*:4
<function "f">( <arguments> )
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/bad-array-undef-1.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ gap> f := function()
function( ) ... end
gap> f();
Error, Variable: 'm' must have an assigned value
Stack trace:
*[1] return l[m];
@ *stdin*:5
<function "f">( <arguments> )
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/bad-minus.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ function( ) ... end
gap> f();
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `AdditiveInverseMutable' on 1 arguments
Stack trace:
*[1] AdditiveInverseMutable( elm )
@ GAPROOT/lib/arith.gi:LINE
[2] AdditiveInverseImmutable( elm )
Expand Down
1 change: 0 additions & 1 deletion tst/testspecial/break-loop-loop.g.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ gap> i:=0;
0
gap> f(1);
Error, bar
Stack trace:
*[1] Error( "bar" );
@ *stdin*:3
<function "f">( <arguments> )
Expand Down
Loading
Loading