Fix Vuetify 4 migration leftovers - #3094
Conversation
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFrontend templates update DNS and account slot bindings, replace the DNS management wrapper, adjust component spacing, and remove a Vuetify toolbar padding override. ChangesFrontend template and style updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM label has been added. DetailsGit tree hash: 473ace49300d0444ce96810a94241ed63058b22a |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petersutter The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area usability
/kind regression
What this PR does / why we need it:
Vuetify 4 exposes the raw list item as
iteminVSelectandVAutocompleteslots. Several string-based selectors still accesseditem.valueoritem.title, causing selected DNS provider labels and icons to render empty and owner autocomplete entries to appear as "Unknown".This change:
The changes are limited to rendering and layout. They do not change credential or Secret handling, DNS configuration models, or generated Gardener resources.
Which issue(s) this PR fixes:
None.
Validation:
make verifygit diff --checkRelease note:
Summary by CodeRabbit
Bug Fixes
Style