Skip to content

Fix Vuetify 4 migration leftovers - #3094

Merged
gardener-prow[bot] merged 3 commits into
masterfrom
enh/fix-vuetify4-leftovers
Jul 22, 2026
Merged

Fix Vuetify 4 migration leftovers#3094
gardener-prow[bot] merged 3 commits into
masterfrom
enh/fix-vuetify4-leftovers

Conversation

@grolu

@grolu grolu commented Jul 21, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/area usability
/kind regression

What this PR does / why we need it:

Vuetify 4 exposes the raw list item as item in VSelect and VAutocomplete slots. Several string-based selectors still accessed item.value or item.title, causing selected DNS provider labels and icons to render empty and owner autocomplete entries to appear as "Unknown".

This change:

  • uses the raw provider string in the primary and shoot-dns-service DNS selectors
  • uses the raw username in the project-owner autocomplete
  • restores breadcrumb, DNS configuration, and control-plane high-availability spacing left over from the Vuetify 4 migration

The changes are limited to rendering and layout. They do not change credential or Secret handling, DNS configuration models, or generated Gardener resources.

Which issue(s) this PR fixes:

None.

Validation:

  • make verify
  • changed-file ESLint
  • git diff --check

Release note:

NONE

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the displayed DNS provider type text (and associated icon) in DNS provider selection.
    • Fixed account avatar rendering in account autocomplete selections.
    • Improved breadcrumb layout spacing for non-linked breadcrumb items.
  • Style

    • Refined spacing/layout in DNS management, including the outer wrapper and cluster domain row spacing.
    • Adjusted vertical padding for the Control Plane High Availability section.
    • Updated app bar toolbar spacing by removing a stylesheet override.

@gardener-prow

gardener-prow Bot commented Jul 21, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/usability Usability related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution labels Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7dc1d032-95c7-4777-baf3-1572ba47d975

📥 Commits

Reviewing files that changed from the base of the PR and between a122040 and 764c9bf.

📒 Files selected for processing (1)
  • frontend/src/components/GBreadcrumb.vue

📝 Walkthrough

Walkthrough

Frontend templates update DNS and account slot bindings, replace the DNS management wrapper, adjust component spacing, and remove a Vuetify toolbar padding override.

Changes

Frontend template and style updates

Layer / File(s) Summary
Selection and item bindings
frontend/src/components/ShootDns/GDnsProviderRow.vue, frontend/src/components/ShootDns/GManageDns.vue, frontend/src/components/editable/GEditableAccount.vue
DNS provider selection slots and account autocomplete avatars now consume direct slot item values.
DNS layout structure
frontend/src/components/ShootDns/GManageDns.vue
The DNS management wrapper uses a plain div, and the cluster-domain row spacing is updated.
Component spacing
frontend/src/components/GBreadcrumb.vue, frontend/src/views/GNewShoot.vue
Breadcrumb and high-availability card spacing classes are adjusted.
Toolbar padding override
frontend/src/sass/main.scss
The .v-app-bar .v-toolbar__content inline padding override is removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: kind/cleanup

Suggested reviewers: holgerkoser, klocke-io

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the Vuetify 4 migration cleanup.
Description check ✅ Passed The description covers purpose, scope, validation, and release note; only the reviewer notes section is missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch enh/fix-vuetify4-leftovers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gardener-prow gardener-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 21, 2026
@grolu
grolu marked this pull request as ready for review July 22, 2026 07:29
@grolu
grolu requested a review from a team as a code owner July 22, 2026 07:29
@gardener-prow gardener-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2026
@gardener-prow gardener-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2026

@petersutter petersutter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2026
@gardener-prow

gardener-prow Bot commented Jul 22, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 473ace49300d0444ce96810a94241ed63058b22a

@gardener-prow

gardener-prow Bot commented Jul 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petersutter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2026
@gardener-prow
gardener-prow Bot merged commit b51fb00 into master Jul 22, 2026
38 checks passed
@gardener-prow
gardener-prow Bot deleted the enh/fix-vuetify4-leftovers branch July 22, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants