Skip to content

Adapt VPA resources to explicitly specify update mode InPlaceOrRecreate#412

Open
Velin-Todorov wants to merge 1 commit into
gardener:mainfrom
Velin-Todorov:enable-in-place-vpa-updates
Open

Adapt VPA resources to explicitly specify update mode InPlaceOrRecreate#412
Velin-Todorov wants to merge 1 commit into
gardener:mainfrom
Velin-Todorov:enable-in-place-vpa-updates

Conversation

@Velin-Todorov

Copy link
Copy Markdown

What this PR does / why we need it:
The changes in this PR explicitly set the update mode of the VPA resources to InPlaceOrRecreate. Doing so will allow us to remove the GRM webhook in a future release, as it is currently unconditionally enabled.

Which issue(s) this PR fixes:
Part of gardener/gardener#12955

Special notes for your reviewer:
N/A

Release note:

The update mode of the VerticalPodAutoscaler resource, deployed by oidc-apps-controller,  is now explicitly set to `InPlaceOrRecreate`, reflecting the actual runtime behavior after the unconditional enablement of the `VPAInPlaceUpdates` feature gate.

@Velin-Todorov
Velin-Todorov requested a review from iypetrov as a code owner July 22, 2026 09:32
@gardener-prow

gardener-prow Bot commented Jul 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nickytd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2026
@hyperspace-pr-bot

Copy link
Copy Markdown

Summary

The following content is AI-generated and provides a summary of the pull request:


How to categorize this PR?
/kind task
/area oidc-apps

What this PR does / why we need it:
This PR explicitly sets the updateMode of the VerticalPodAutoscaler resources deployed by the oidc-apps-controller from Recreate to InPlaceOrRecreate. This change reflects the actual runtime behavior following the unconditional enablement of the VPAInPlaceUpdates feature gate in Gardener, and is a prerequisite for removing the Gardener Resource Manager (GRM) mutating webhook that was previously responsible for injecting this update mode.

Code changes:

  • Updated charts/oidc-apps-controller/values.yaml: Changed the default VPA updateMode from "Recreate" to "InPlaceOrRecreate".
  • Updated pkg/webhook/test/vpa-mutating-webhook_test.go: Changed test fixtures for both target and non-target VPA objects to use UpdateModeInPlaceOrRecreate instead of UpdateModeRecreate.
  • Updated test/e2e/crds/vpa-v1-crd-gen.yaml: Added InPlaceOrRecreate as a valid enum value for the updateMode field in the VPA CRD, aligning with upstream VPA changes.
  • Updated example/controller-registration.yaml: Regenerated the embedded Helm chart with the updated VPA update mode value.

Additional context:
This is part of the broader Gardener initiative (gardener/gardener#12955) to enable in-place Pod resource updates for native Gardener components. Once all extensions and components have adopted InPlaceOrRecreate explicitly, the GRM webhook can be safely removed.

Which issue(s) this PR fixes:
Part of gardener/gardener#12955

Special notes for your reviewer:
N/A

Release note:

The update mode of the `VerticalPodAutoscaler` resource deployed by `oidc-apps-controller` is now explicitly set to `InPlaceOrRecreate`, reflecting the actual runtime behavior after the unconditional enablement of the `VPAInPlaceUpdates` feature gate.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.28.2

@gardener-prow gardener-prow Bot added the kind/task General task label Jul 22, 2026
@gardener-prow

gardener-prow Bot commented Jul 22, 2026

Copy link
Copy Markdown

@hyperspace-pr-bot[bot]: The label(s) area/oidc-apps cannot be applied, because the repository doesn't have them.

Details

In response to this:

Summary

The following content is AI-generated and provides a summary of the pull request:


How to categorize this PR?
/kind task
/area oidc-apps

What this PR does / why we need it:
This PR explicitly sets the updateMode of the VerticalPodAutoscaler resources deployed by the oidc-apps-controller from Recreate to InPlaceOrRecreate. This change reflects the actual runtime behavior following the unconditional enablement of the VPAInPlaceUpdates feature gate in Gardener, and is a prerequisite for removing the Gardener Resource Manager (GRM) mutating webhook that was previously responsible for injecting this update mode.

Code changes:

  • Updated charts/oidc-apps-controller/values.yaml: Changed the default VPA updateMode from "Recreate" to "InPlaceOrRecreate".
  • Updated pkg/webhook/test/vpa-mutating-webhook_test.go: Changed test fixtures for both target and non-target VPA objects to use UpdateModeInPlaceOrRecreate instead of UpdateModeRecreate.
  • Updated test/e2e/crds/vpa-v1-crd-gen.yaml: Added InPlaceOrRecreate as a valid enum value for the updateMode field in the VPA CRD, aligning with upstream VPA changes.
  • Updated example/controller-registration.yaml: Regenerated the embedded Helm chart with the updated VPA update mode value.

Additional context:
This is part of the broader Gardener initiative (gardener/gardener#12955) to enable in-place Pod resource updates for native Gardener components. Once all extensions and components have adopted InPlaceOrRecreate explicitly, the GRM webhook can be safely removed.

Which issue(s) this PR fixes:
Part of gardener/gardener#12955

Special notes for your reviewer:
N/A

Release note:

The update mode of the `VerticalPodAutoscaler` resource deployed by `oidc-apps-controller` is now explicitly set to `InPlaceOrRecreate`, reflecting the actual runtime behavior after the unconditional enablement of the `VPAInPlaceUpdates` feature gate.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.28.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow Bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/task General task size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant