Skip to content

Adapt VPA resources to explicitly specify update mode InPlaceOrRecreate #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Velin-Todorov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adapt VPA resources to explicitly specify update mode InPlaceOrRecreate #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/oidc-apps-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ priorityClass:
vpa:
enabled: true
updatePolicy:
updateMode: "Recreate"
updateMode: "InPlaceOrRecreate"
# evictionRequirements:
# - resources: ["cpu", "memory"]
# changeRequirement: TargetHigherThanRequests
Expand Down
2 changes: 1 addition & 1 deletion example/controller-registration.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions pkg/webhook/test/vpa-mutating-webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func initTargetVPA() {
APIVersion: "apps/v1",
},
UpdatePolicy: &autoscalerv1.PodUpdatePolicy{
UpdateMode: ptr.To(autoscalerv1.UpdateModeRecreate),
UpdateMode: ptr.To(autoscalerv1.UpdateModeInPlaceOrRecreate),
},
ResourcePolicy: &autoscalerv1.PodResourcePolicy{
ContainerPolicies: []autoscalerv1.ContainerResourcePolicy{
Expand Down Expand Up @@ -107,7 +107,7 @@ func initNonTargetVPA() {
APIVersion: "apps/v1",
},
UpdatePolicy: &autoscalerv1.PodUpdatePolicy{
UpdateMode: ptr.To(autoscalerv1.UpdateModeRecreate),
UpdateMode: ptr.To(autoscalerv1.UpdateModeInPlaceOrRecreate),
},
ResourcePolicy: &autoscalerv1.PodResourcePolicy{
ContainerPolicies: []autoscalerv1.ContainerResourcePolicy{
Expand Down
2 changes: 2 additions & 0 deletions test/e2e/crds/vpa-v1-crd-gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ spec:
- Initial
- Recreate
- Auto
- InPlaceOrRecreate
type: string
type: object
required:
Expand Down Expand Up @@ -665,6 +666,7 @@ spec:
- Initial
- Recreate
- Auto
- InPlaceOrRecreate
type: string
type: object
required:
Expand Down
Loading