Skip to content

fix: guard mqtt cleanup on setup errors #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gavinying merged 1 commit into from
Dec 6, 2025
Merged

fix: guard mqtt cleanup on setup errors #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions modpoll/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,22 @@ def app(name="modpoll"):
logger.info("Connected to MQTT broker.")
else:
logger.error("Failed to connect with MQTT broker, exiting...")
mqtt_handler.close()
try:
mqtt_handler.close()
except Exception as close_err:
logger.debug(
f"Ignoring MQTT close error after failed connect: {close_err}"
)
exit(1)
except Exception as e:
logger.error(f"Error setting up MQTT input: {e}, exiting...")
mqtt_handler.close()
if mqtt_handler:
try:
mqtt_handler.close()
except Exception as close_err:
logger.debug(
f"Ignoring MQTT close error after setup exception: {close_err}"
)
exit(1)

# setup modbus tasks
Expand Down