feat(core)!: Remove streamGenAiSpans flag - #22495
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
nicohrubec
force-pushed
the
feat/remove-stream-gen-ai-spans-flag
branch
3 times, most recently
from
July 22, 2026 14:54
3a1b409 to
29f97f5
Compare
nicohrubec
marked this pull request as ready for review
July 23, 2026 07:34
nicohrubec
requested review from
JPeer264,
andreiborza and
isaacs
and removed request for
a team
July 23, 2026 07:34
andreiborza
approved these changes
Jul 23, 2026
This was referenced Jul 23, 2026
isaacs
approved these changes
Jul 24, 2026
Removes the `streamGenAiSpans` client option. The behavior it gated (extracting gen_ai spans from transactions into a v2 span envelope container) was already the default and is now unconditional — there is no longer a way to opt out. For static transactions, `extractGenAiSpansFromEvent` always pulls gen_ai spans into a v2 span container. For full span streaming (`traceLifecycle: 'stream'`), the existing `hasSpanStreamingEnabled` guard still short-circuits so spans are not extracted twice. Because gen_ai spans now always take the v2 path (not subject to the transaction payload-size limits that truncation works around), `shouldEnableTruncation` simplifies to `!getClient()`. The `enableTruncation` escape hatch is intentionally left in place for a follow-up. Test suites that set `streamGenAiSpans: false` to assert on `transaction.spans` are migrated to assert on the v2 span container; redundant `streamGenAiSpans: true` config lines are removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
feat/remove-stream-gen-ai-spans-flag
branch
from
July 29, 2026 08:09
29f97f5 to
428912c
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6252455. Configure here.
…flare-agent e2e app The cloudflare-agent e2e app landed on develop after this branch was cut and still set `streamGenAiSpans: false` to keep gen_ai spans embedded in the transaction. With the flag gone, gen_ai spans always stream as a separate span container, so the app dropped the option and the AI streaming test now asserts on the streamed span (matched to the request via the transaction trace id). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
feat/remove-stream-gen-ai-spans-flag
branch
from
July 29, 2026 08:46
6252455 to
ab3644f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
streamGenAiSpansclient option, making the extraction of gen_ai spans into a v2 span envelope container the unconditional default (it was already the default via@default true). Truncation logic will be removed in a follow up.Related to #21129