Skip to content

Major changes#3

Open
gillg wants to merge 3 commits into
masterfrom
initial-refactoring
Open

Major changes#3
gillg wants to merge 3 commits into
masterfrom
initial-refactoring

Conversation

@gillg

@gillg gillg commented Jan 28, 2018

Copy link
Copy Markdown
Owner

No description provided.

@gillg

gillg commented Jan 28, 2018

Copy link
Copy Markdown
Owner Author

From #1 :

Thanks for your improvments ! This module is in testing phase, and I had some issues with configuration settings.
Your PR contains some good things but also other wired. Why do you add user and password in settings ? This is not the goal of an LDAP auth ?

@gillg gillg mentioned this pull request Jan 28, 2018
@gillg

gillg commented Jan 29, 2018

Copy link
Copy Markdown
Owner Author

We have also to make login case insensitive.

@gillg
gillg force-pushed the initial-refactoring branch from 97a9027 to 91e8443 Compare February 3, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant