fix(build): add top level links to binaries#1382
Merged
Conversation
It seems that we need dataplane, init, and the cli available from / Signed-off-by: Daniel Noland <daniel@githedgehog.com>
mvachhar
approved these changes
Mar 24, 2026
mvachhar
requested review from
Copilot and
sergeymatov
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Nix build output layout so key executables are reachable from the filesystem root (/) in addition to /bin, matching environments/tools that expect those paths.
Changes:
- Add root-level symlinks for
dataplane,cli, anddataplane-initin the tarball staging directory.
| ln -s "${workspace.cli}/bin/cli" "$tmp/bin/cli" | ||
| ln -s "${workspace.init}/bin/dataplane-init" "$tmp/bin/dataplane-init" | ||
| ln -s "${workspace.dataplane}/bin/dataplane" "$tmp/dataplane" | ||
| ln -s "${workspace.cli}/bin/cli" "$tmp/dataplane-cli" |
There was a problem hiding this comment.
confidence: 9
tags: [logic]The PR description says the CLI should be available from "/", but the new top-level symlink is named "dataplane-cli" while the actual binary is "cli" (and there are no other references to a "/dataplane-cli" path in the repo). This likely won’t satisfy callers expecting "/cli".
Consider linking the CLI to "$tmp/cli" (or otherwise align the top-level filename with the intended contract) to make the CLI available at the expected path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that we need dataplane, init, and the cli available from /