Skip to content

fix(build): add top level links to binaries #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvachhar merged 1 commit into from
Mar 24, 2026
+3 −0
Merged

fix(build): add top level links to binaries #1382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,9 @@ let
ln -s "${workspace.dataplane}/bin/dataplane" "$tmp/bin/dataplane"
ln -s "${workspace.cli}/bin/cli" "$tmp/bin/cli"
ln -s "${workspace.init}/bin/dataplane-init" "$tmp/bin/dataplane-init"
ln -s "${workspace.dataplane}/bin/dataplane" "$tmp/dataplane"
ln -s "${workspace.cli}/bin/cli" "$tmp/dataplane-cli"
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

confidence: 9
tags: [logic]

The PR description says the CLI should be available from "/", but the new top-level symlink is named "dataplane-cli" while the actual binary is "cli" (and there are no other references to a "/dataplane-cli" path in the repo). This likely won’t satisfy callers expecting "/cli".

Consider linking the CLI to "$tmp/cli" (or otherwise align the top-level filename with the intended contract) to make the CLI available at the expected path.

Copilot uses AI. Check for mistakes.
ln -s "${workspace.init}/bin/dataplane-init" "$tmp/dataplane-init"
for i in "${pkgs.pkgsHostHost.busybox}/bin/"*; do
ln -s "${pkgs.pkgsHostHost.busybox}/bin/busybox" "$tmp/bin/$(basename "$i")"
done
Expand Down
Loading