fix: Replace logo icon#56
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates brand assets (favicons and touch icons) across the monorepo to use a new logo mark, and refreshes the Rails sign-in page logo accordingly.
Changes:
- Replaced multiple
apple-touch-icon*andmaskable-apple-touch-icon*PNG variants (includingdev/ngrokvariants) forapps/web. - Replaced
favicon.svginapps/web,apps/site, andapi, plus updated related PNG/ICO icon assets. - Updated the Rails sign-in view to render the new logo SVG inline.
Reviewed changes
Copilot reviewed 1 out of 53 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/public/meta/maskable-apple-touch-icon.png | Updates maskable Apple touch icon asset. |
| apps/web/public/meta/maskable-apple-touch-icon-ngrok.png | Updates ngrok maskable Apple touch icon asset. |
| apps/web/public/meta/maskable-apple-touch-icon-ngrok-512.png | Updates ngrok maskable Apple touch icon (512px). |
| apps/web/public/meta/maskable-apple-touch-icon-ngrok-192.png | Updates ngrok maskable Apple touch icon (192px). |
| apps/web/public/meta/maskable-apple-touch-icon-ngrok-180.png | Updates ngrok maskable Apple touch icon (180px). |
| apps/web/public/meta/maskable-apple-touch-icon-ngrok-128.png | Updates ngrok maskable Apple touch icon (128px). |
| apps/web/public/meta/maskable-apple-touch-icon-ngrok-120.png | Updates ngrok maskable Apple touch icon (120px). |
| apps/web/public/meta/maskable-apple-touch-icon-dev.png | Updates dev maskable Apple touch icon asset. |
| apps/web/public/meta/maskable-apple-touch-icon-dev-512.png | Updates dev maskable Apple touch icon (512px). |
| apps/web/public/meta/maskable-apple-touch-icon-dev-192.png | Updates dev maskable Apple touch icon (192px). |
| apps/web/public/meta/maskable-apple-touch-icon-dev-180.png | Updates dev maskable Apple touch icon (180px). |
| apps/web/public/meta/maskable-apple-touch-icon-dev-128.png | Updates dev maskable Apple touch icon (128px). |
| apps/web/public/meta/maskable-apple-touch-icon-dev-120.png | Updates dev maskable Apple touch icon (120px). |
| apps/web/public/meta/maskable-apple-touch-icon-512.png | Updates maskable Apple touch icon (512px). |
| apps/web/public/meta/maskable-apple-touch-icon-192.png | Updates maskable Apple touch icon (192px). |
| apps/web/public/meta/maskable-apple-touch-icon-180.png | Updates maskable Apple touch icon (180px). |
| apps/web/public/meta/maskable-apple-touch-icon-128.png | Updates maskable Apple touch icon (128px). |
| apps/web/public/meta/maskable-apple-touch-icon-120.png | Updates maskable Apple touch icon (120px). |
| apps/web/public/meta/apple-touch-icon.png | Updates Apple touch icon asset. |
| apps/web/public/meta/apple-touch-icon-ngrok.png | Updates ngrok Apple touch icon asset. |
| apps/web/public/meta/apple-touch-icon-ngrok-512.png | Updates ngrok Apple touch icon (512px). |
| apps/web/public/meta/apple-touch-icon-ngrok-192.png | Updates ngrok Apple touch icon (192px). |
| apps/web/public/meta/apple-touch-icon-ngrok-180.png | Updates ngrok Apple touch icon (180px). |
| apps/web/public/meta/apple-touch-icon-ngrok-128.png | Updates ngrok Apple touch icon (128px). |
| apps/web/public/meta/apple-touch-icon-ngrok-120.png | Updates ngrok Apple touch icon (120px). |
| apps/web/public/meta/apple-touch-icon-dev.png | Updates dev Apple touch icon asset. |
| apps/web/public/meta/apple-touch-icon-dev-512.png | Updates dev Apple touch icon (512px). |
| apps/web/public/meta/apple-touch-icon-dev-192.png | Updates dev Apple touch icon (192px). |
| apps/web/public/meta/apple-touch-icon-dev-180.png | Updates dev Apple touch icon (180px). |
| apps/web/public/meta/apple-touch-icon-dev-128.png | Updates dev Apple touch icon (128px). |
| apps/web/public/meta/apple-touch-icon-dev-120.png | Updates dev Apple touch icon (120px). |
| apps/web/public/meta/apple-touch-icon-192.png | Updates Apple touch icon (192px). |
| apps/web/public/meta/apple-touch-icon-180.png | Updates Apple touch icon (180px). |
| apps/web/public/meta/apple-touch-icon-128.png | Updates Apple touch icon (128px). |
| apps/web/public/meta/apple-touch-icon-120.png | Updates Apple touch icon (120px). |
| apps/web/public/favicon.svg | Replaces the web app SVG favicon asset. |
| apps/site/public/meta/apple-touch-icon.png | Updates site Apple touch icon asset. |
| apps/site/public/meta/android-chrome-192x192.png | Updates site Android chrome icon (192px). |
| apps/site/public/favicon.svg | Replaces the site SVG favicon asset. |
| api/public/favicon.svg | Replaces the API SVG favicon asset. |
| api/public/favicon.ico | Replaces the API ICO favicon asset. |
| api/public/apple-touch-icon.png | Updates API Apple touch icon asset. |
| api/public/apple-touch-icon-192.png | Updates API Apple touch icon (192px). |
| api/public/android-chrome-512x512.png | Updates API Android chrome icon (512px). |
| api/public/android-chrome-192x192.png | Updates API Android chrome icon (192px). |
| api/public/desktop-app-icon.png | Updates API desktop app icon asset. |
| api/app/views/users/sessions/new.html.erb | Updates the Rails sign-in page logo rendering and related copy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+27
| <svg width="49" height="49" viewBox="0 0 356 356" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <path d="M146.152 34.3454L178.06 3.02734L209.948 34.3454H146.152Z" fill="#9DD7FF"/> | ||
| <path d="M127.29 3.1875H178.129L146.147 34.3508L103.109 23.3889L127.29 3.1875Z" fill="#3EA5DF"/> | ||
| <path d="M228.969 3.1875H178.129L209.952 34.3534L253.301 23.5009L228.969 3.1875Z" fill="#BCE3FF"/> | ||
| <path d="M79.5781 57.0409L103.115 23.3867L146.337 34.3955L97.5997 94.1505L79.5781 57.0409Z" fill="#006BBF"/> | ||
| <path d="M276.602 57.0409L253.065 23.3867L209.962 34.346L258.706 93.8747L276.602 57.0409Z" fill="#9BD4F0"/> | ||
| <path d="M156.127 54.0289L146.159 34.3555L97.6016 94.1468L156.127 54.0289Z" fill="#80CBF5"/> | ||
| <path d="M200.053 54.0276L209.959 34.3438L258.699 93.8552L200.053 54.0276Z" fill="#CFF7FF"/> | ||
| <path d="M200.176 54.0809H156.122L146.152 34.3438H209.961L200.176 54.0809Z" fill="#E1F7FC"/> | ||
| <path d="M147.699 59.8026L156.123 54.082H200.262L208.537 59.8271L179.382 90.2929L147.699 59.8026Z" fill="#0155A6"/> | ||
| <path d="M10.2266 248.042L79.6524 57.1289L110.188 118.976L102.013 304.902L10.2266 248.042Z" fill="#003153"/> | ||
| <path d="M345.945 248.982L276.519 57.1289L246.189 119.17L254.162 305.189L345.945 248.982Z" fill="#9BD4F0"/> | ||
| <path d="M178.148 352.969L102.008 304.899L109.888 119.117L178.182 141.467L178.148 352.969Z" fill="#076AAF"/> | ||
| <path d="M178.144 352.972L254.164 305.186L246.283 119.117L178.144 141.467V352.972Z" fill="#69B7E1"/> | ||
| <path d="M132.215 150.921L149.682 116.359H221.568L230.829 150.921H132.215Z" fill="#076AAF"/> | ||
| <path d="M137.696 212.598L125.809 149.432L147.953 135.68L137.696 212.598Z" fill="#E1F7FC"/> | ||
| <path d="M221.777 212.598L233.664 149.432L211.52 135.68L221.777 212.598Z" fill="#E1F7FC"/> | ||
| <path d="M92.9492 124.136L97.6016 94.1434L147.696 59.8008L179.378 90.284V122.727L120.262 158.119L100.002 143.629L92.9492 124.136Z" fill="#0E86D4"/> | ||
| <path d="M265.809 124.135L258.714 93.8151L208.519 59.8164L179.38 90.2822V122.725L238.495 158.117L258.756 143.627L265.809 124.135Z" fill="#71C8FB"/> | ||
| <circle cx="122.372" cy="49.0084" r="8.11782" fill="#042A69"/> | ||
| <circle cx="233.844" cy="49.0084" r="8.11782" fill="#042A69"/> | ||
| </svg> |
There was a problem hiding this comment.
The inlined logo SVG here is a different asset/style (full-color, 356x356 viewBox) than the current logo used across the other auth/admin templates (the 49x24 currentColor mark). This will make the Rails UI inconsistent and also duplicates a large SVG blob in a single view. Consider extracting a shared partial (e.g., shared/_logo.svg) and updating all pages that render the logo to use the same source (or referencing a public asset like /favicon.svg).
Suggested change
| <svg width="49" height="49" viewBox="0 0 356 356" fill="none" xmlns="http://www.w3.org/2000/svg"> | |
| <path d="M146.152 34.3454L178.06 3.02734L209.948 34.3454H146.152Z" fill="#9DD7FF"/> | |
| <path d="M127.29 3.1875H178.129L146.147 34.3508L103.109 23.3889L127.29 3.1875Z" fill="#3EA5DF"/> | |
| <path d="M228.969 3.1875H178.129L209.952 34.3534L253.301 23.5009L228.969 3.1875Z" fill="#BCE3FF"/> | |
| <path d="M79.5781 57.0409L103.115 23.3867L146.337 34.3955L97.5997 94.1505L79.5781 57.0409Z" fill="#006BBF"/> | |
| <path d="M276.602 57.0409L253.065 23.3867L209.962 34.346L258.706 93.8747L276.602 57.0409Z" fill="#9BD4F0"/> | |
| <path d="M156.127 54.0289L146.159 34.3555L97.6016 94.1468L156.127 54.0289Z" fill="#80CBF5"/> | |
| <path d="M200.053 54.0276L209.959 34.3438L258.699 93.8552L200.053 54.0276Z" fill="#CFF7FF"/> | |
| <path d="M200.176 54.0809H156.122L146.152 34.3438H209.961L200.176 54.0809Z" fill="#E1F7FC"/> | |
| <path d="M147.699 59.8026L156.123 54.082H200.262L208.537 59.8271L179.382 90.2929L147.699 59.8026Z" fill="#0155A6"/> | |
| <path d="M10.2266 248.042L79.6524 57.1289L110.188 118.976L102.013 304.902L10.2266 248.042Z" fill="#003153"/> | |
| <path d="M345.945 248.982L276.519 57.1289L246.189 119.17L254.162 305.189L345.945 248.982Z" fill="#9BD4F0"/> | |
| <path d="M178.148 352.969L102.008 304.899L109.888 119.117L178.182 141.467L178.148 352.969Z" fill="#076AAF"/> | |
| <path d="M178.144 352.972L254.164 305.186L246.283 119.117L178.144 141.467V352.972Z" fill="#69B7E1"/> | |
| <path d="M132.215 150.921L149.682 116.359H221.568L230.829 150.921H132.215Z" fill="#076AAF"/> | |
| <path d="M137.696 212.598L125.809 149.432L147.953 135.68L137.696 212.598Z" fill="#E1F7FC"/> | |
| <path d="M221.777 212.598L233.664 149.432L211.52 135.68L221.777 212.598Z" fill="#E1F7FC"/> | |
| <path d="M92.9492 124.136L97.6016 94.1434L147.696 59.8008L179.378 90.284V122.727L120.262 158.119L100.002 143.629L92.9492 124.136Z" fill="#0E86D4"/> | |
| <path d="M265.809 124.135L258.714 93.8151L208.519 59.8164L179.38 90.2822V122.725L238.495 158.117L258.756 143.627L265.809 124.135Z" fill="#71C8FB"/> | |
| <circle cx="122.372" cy="49.0084" r="8.11782" fill="#042A69"/> | |
| <circle cx="233.844" cy="49.0084" r="8.11782" fill="#042A69"/> | |
| </svg> | |
| <%= image_tag '/favicon.svg', | |
| width: 49, | |
| height: 49, | |
| alt: "#{Rails.configuration.x.app_name} logo" %> |
Comment on lines
58
to
62
| <%= form_for(resource, as: resource_name, url: user_session_path, html: { class: "w-full space-y-5" }) do |f| %> | ||
| <%= render "users/shared/errors", resource: resource %> | ||
|
|
||
| <span>账户密码登录功能仅供Demo，测试请使用Github登录</span> | ||
| <div class="form-group"> | ||
| <%= f.label(:email) %> |
There was a problem hiding this comment.
This PR is titled as an icon replacement, but this change removes user-facing copy about demo password login (previously indicating to use GitHub login). If the message is still needed for users, keep it (or replace with updated English copy); otherwise, please update the PR description/title to reflect the behavior/content change.
benjamin-747
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.