Skip to content

fix: Replace logo icon #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjamin-747 merged 1 commit into from
Feb 26, 2026
Merged

fix: Replace logo icon #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions api/app/views/users/sessions/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,29 @@
<main class="outer-container">
<div class="inner-container">
<div class="page-title-container">
<svg width="49" height="20" viewBox="0 0 49 24" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M0.201982 21.9532L13.7942 0.654571C14.0531 0.248924 14.5245 0 15.0338 0H37.1765C38.2907 0 38.9824 1.12038 38.4161 2.00776L24.8238 23.3064C24.565 23.7121 24.0936 23.961 23.5843 23.961H1.44157C0.327401 23.961 -0.364321 22.8406 0.201982 21.9532Z" fill="currentColor"/>
<path d="M32.0309 23.9609H47.4978C48.5832 23.9609 49.2781 22.8922 48.7691 22.0055L41.4653 9.28149C40.9386 8.36398 39.5292 8.33304 38.9561 9.22642L30.793 21.9505C30.2237 22.8378 30.9152 23.9609 32.0309 23.9609Z" fill="currentColor"/>
</svg>
<svg width="49" height="49" viewBox="0 0 356 356" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M146.152 34.3454L178.06 3.02734L209.948 34.3454H146.152Z" fill="#9DD7FF"/>
<path d="M127.29 3.1875H178.129L146.147 34.3508L103.109 23.3889L127.29 3.1875Z" fill="#3EA5DF"/>
<path d="M228.969 3.1875H178.129L209.952 34.3534L253.301 23.5009L228.969 3.1875Z" fill="#BCE3FF"/>
<path d="M79.5781 57.0409L103.115 23.3867L146.337 34.3955L97.5997 94.1505L79.5781 57.0409Z" fill="#006BBF"/>
<path d="M276.602 57.0409L253.065 23.3867L209.962 34.346L258.706 93.8747L276.602 57.0409Z" fill="#9BD4F0"/>
<path d="M156.127 54.0289L146.159 34.3555L97.6016 94.1468L156.127 54.0289Z" fill="#80CBF5"/>
<path d="M200.053 54.0276L209.959 34.3438L258.699 93.8552L200.053 54.0276Z" fill="#CFF7FF"/>
<path d="M200.176 54.0809H156.122L146.152 34.3438H209.961L200.176 54.0809Z" fill="#E1F7FC"/>
<path d="M147.699 59.8026L156.123 54.082H200.262L208.537 59.8271L179.382 90.2929L147.699 59.8026Z" fill="#0155A6"/>
<path d="M10.2266 248.042L79.6524 57.1289L110.188 118.976L102.013 304.902L10.2266 248.042Z" fill="#003153"/>
<path d="M345.945 248.982L276.519 57.1289L246.189 119.17L254.162 305.189L345.945 248.982Z" fill="#9BD4F0"/>
<path d="M178.148 352.969L102.008 304.899L109.888 119.117L178.182 141.467L178.148 352.969Z" fill="#076AAF"/>
<path d="M178.144 352.972L254.164 305.186L246.283 119.117L178.144 141.467V352.972Z" fill="#69B7E1"/>
<path d="M132.215 150.921L149.682 116.359H221.568L230.829 150.921H132.215Z" fill="#076AAF"/>
<path d="M137.696 212.598L125.809 149.432L147.953 135.68L137.696 212.598Z" fill="#E1F7FC"/>
<path d="M221.777 212.598L233.664 149.432L211.52 135.68L221.777 212.598Z" fill="#E1F7FC"/>
<path d="M92.9492 124.136L97.6016 94.1434L147.696 59.8008L179.378 90.284V122.727L120.262 158.119L100.002 143.629L92.9492 124.136Z" fill="#0E86D4"/>
<path d="M265.809 124.135L258.714 93.8151L208.519 59.8164L179.38 90.2822V122.725L238.495 158.117L258.756 143.627L265.809 124.135Z" fill="#71C8FB"/>
<circle cx="122.372" cy="49.0084" r="8.11782" fill="#042A69"/>
<circle cx="233.844" cy="49.0084" r="8.11782" fill="#042A69"/>
</svg>
Comment on lines +6 to +27

Copilot AI Feb 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inlined logo SVG here is a different asset/style (full-color, 356x356 viewBox) than the current logo used across the other auth/admin templates (the 49x24 currentColor mark). This will make the Rails UI inconsistent and also duplicates a large SVG blob in a single view. Consider extracting a shared partial (e.g., shared/_logo.svg) and updating all pages that render the logo to use the same source (or referencing a public asset like /favicon.svg).

Suggested change
<svg width="49" height="49" viewBox="0 0 356 356" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M146.152 34.3454L178.06 3.02734L209.948 34.3454H146.152Z" fill="#9DD7FF"/>
<path d="M127.29 3.1875H178.129L146.147 34.3508L103.109 23.3889L127.29 3.1875Z" fill="#3EA5DF"/>
<path d="M228.969 3.1875H178.129L209.952 34.3534L253.301 23.5009L228.969 3.1875Z" fill="#BCE3FF"/>
<path d="M79.5781 57.0409L103.115 23.3867L146.337 34.3955L97.5997 94.1505L79.5781 57.0409Z" fill="#006BBF"/>
<path d="M276.602 57.0409L253.065 23.3867L209.962 34.346L258.706 93.8747L276.602 57.0409Z" fill="#9BD4F0"/>
<path d="M156.127 54.0289L146.159 34.3555L97.6016 94.1468L156.127 54.0289Z" fill="#80CBF5"/>
<path d="M200.053 54.0276L209.959 34.3438L258.699 93.8552L200.053 54.0276Z" fill="#CFF7FF"/>
<path d="M200.176 54.0809H156.122L146.152 34.3438H209.961L200.176 54.0809Z" fill="#E1F7FC"/>
<path d="M147.699 59.8026L156.123 54.082H200.262L208.537 59.8271L179.382 90.2929L147.699 59.8026Z" fill="#0155A6"/>
<path d="M10.2266 248.042L79.6524 57.1289L110.188 118.976L102.013 304.902L10.2266 248.042Z" fill="#003153"/>
<path d="M345.945 248.982L276.519 57.1289L246.189 119.17L254.162 305.189L345.945 248.982Z" fill="#9BD4F0"/>
<path d="M178.148 352.969L102.008 304.899L109.888 119.117L178.182 141.467L178.148 352.969Z" fill="#076AAF"/>
<path d="M178.144 352.972L254.164 305.186L246.283 119.117L178.144 141.467V352.972Z" fill="#69B7E1"/>
<path d="M132.215 150.921L149.682 116.359H221.568L230.829 150.921H132.215Z" fill="#076AAF"/>
<path d="M137.696 212.598L125.809 149.432L147.953 135.68L137.696 212.598Z" fill="#E1F7FC"/>
<path d="M221.777 212.598L233.664 149.432L211.52 135.68L221.777 212.598Z" fill="#E1F7FC"/>
<path d="M92.9492 124.136L97.6016 94.1434L147.696 59.8008L179.378 90.284V122.727L120.262 158.119L100.002 143.629L92.9492 124.136Z" fill="#0E86D4"/>
<path d="M265.809 124.135L258.714 93.8151L208.519 59.8164L179.38 90.2822V122.725L238.495 158.117L258.756 143.627L265.809 124.135Z" fill="#71C8FB"/>
<circle cx="122.372" cy="49.0084" r="8.11782" fill="#042A69"/>
<circle cx="233.844" cy="49.0084" r="8.11782" fill="#042A69"/>
</svg>
<%= image_tag '/favicon.svg',
width: 49,
height: 49,
alt: "#{Rails.configuration.x.app_name} logo" %>

Copilot uses AI. Check for mistakes.


<h2 class="page-title">Sign in</h2>

Expand Down Expand Up @@ -39,7 +58,6 @@
<%= form_for(resource, as: resource_name, url: user_session_path, html: { class: "w-full space-y-5" }) do |f| %>
<%= render "users/shared/errors", resource: resource %>

<span>账户密码登录功能仅供Demo，测试请使用Github登录</span>
<div class="form-group">
<%= f.label(:email) %>
Comment on lines 58 to 62

Copilot AI Feb 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is titled as an icon replacement, but this change removes user-facing copy about demo password login (previously indicating to use GitHub login). If the message is still needed for users, keep it (or replace with updated English copy); otherwise, please update the PR description/title to reflect the behavior/content change.

Copilot uses AI. Check for mistakes.
<%= f.email_field(:email, autofocus: true, autocomplete: "email", required: true) %>
Expand Down
Binary file removed api/public/android-chrome-192x192.png
View file
Open in desktop
Binary file not shown.
Binary file removed api/public/android-chrome-512x512.png
View file
Open in desktop
Binary file not shown.
Binary file added api/public/apple-touch-icon-192.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added api/public/apple-touch-icon-512.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified api/public/apple-touch-icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed api/public/desktop-app-icon.png
View file
Open in desktop
Binary file not shown.
Binary file modified api/public/favicon.ico
View file
Open in desktop
Binary file not shown.
177 changes: 21 additions & 156 deletions api/public/favicon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified apps/site/public/favicon.ico
View file
Open in desktop
Binary file not shown.
Loading