fix: default insecure flag to false for registry create

[madmecodes]

Summary

Fixes #899

The --insecure flag in registry create had its default set to true, which meant every registry was created as insecure even when the user didn't pass --insecure. Changed the default to false so registries are secure by default and the user has to opt in to insecure mode explicitly.

Changes

• cmd/harbor/root/registry/create.go: changed BoolVarP default from true to false

Test plan

• Run harbor registry create --name test --type docker-hub --url https://docker.io without --insecure and verify insecure is false in the output
• Run the same command with --insecure and verify insecure is true

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 8.80%. Comparing base (60ad0bd) to head (0d368e9).
⚠️ Report is 159 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/harbor/root/registry/create.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             main    #913      +/-   ##
=========================================
- Coverage   10.99%   8.80%   -2.19%     
=========================================
  Files         173     280     +107     
  Lines        8671   13965    +5294     
=========================================
+ Hits          953    1230     +277     
- Misses       7612   12618    +5006     
- Partials      106     117      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mreiche]

It will NOT verify the server certifcate

[qcserestipy]

@mreiche you are right. @madmecodes, please go ahead and adapt the flags description such that it uses tls for the registry aka a secure connection.

[qcserestipy]

LGTM, thank you for your contribution. Before merging please adapt the --insecure flags description.

[qcserestipy]

@mreiche you are right. @madmecodes, please go ahead and adapt the flags description such that it uses tls for the registry aka a secure connection.