Skip to content

fix: default insecure flag to false for registry create #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madmecodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: default insecure flag to false for registry create #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/harbor/root/registry/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func CreateRegistryCommand() *cobra.Command {
&opts.Insecure,
"insecure",
"",
true,
false,
"Whether Harbor will verify the server certificate",
)
flags.StringVarP(
Expand Down
2 changes: 1 addition & 1 deletion doc/cli-docs/harbor-registry-create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ harbor registry create
--credential-type string Credential type, such as 'basic', 'oauth' (default "basic")
--description string Description of the registry
-h, --help help for create
--insecure Whether Harbor will verify the server certificate (default true)
--insecure Whether Harbor will verify the server certificate
Copy link
Copy Markdown

@mreiche mreiche May 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will NOT verify the server certifcate

Copy link
Copy Markdown
Collaborator

@qcserestipy qcserestipy May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mreiche you are right. @madmecodes, please go ahead and adapt the flags description such that it uses tls for the registry aka a secure connection.

--name string Name of the registry
--type string Type of the registry
--url string Registry endpoint URL
Expand Down
2 changes: 1 addition & 1 deletion doc/man-docs/man1/harbor-registry-create.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ create registry
help for create

.PP
\fB--insecure\fP[=true]
\fB--insecure\fP[=false]
Whether Harbor will verify the server certificate

.PP
Expand Down