Fix build_and_run_tests.sh command error.#1319
Closed
tsogoo wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I realized another PR #1318 that fixes the error. so i closed. |
Collaborator
|
Oh, wow, wonderful. Thanks for this! |
Collaborator
|
(Yes I've been chatting with @rwgk from the pybind11 team who has been looking at fixing this in a similar way -- but thank you for fixing this nonetheless.) |
This was referenced Mar 7, 2025
Closed
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, kudos to the OpenSpiel team for maintaining such an impressive and valuable framework for reinforcement learning and game theory research!
This PR addresses an issue with the
pybind11dependency in OpenSpiel, stemming from thesmart_holderbranch being archived and renamed toarchive/smart_holderin thepybind11repository (see: https://github.com/pybind/pybind11/tree/archive/smart_holder). The original build process attempted to clone the now-deprecatedsmart_holderbranch, causing errors.Changes Made
pybind11Branch: Modified thecached_clonecommand in./open_spiel/scripts/build_and_run_tests.shto use themasterbranch ofpybind11instead ofsmart_holderorarchive/smart_holder. Thesmart_holderfeatures are now fully integrated intomaster, making this the appropriate target.pybind11migration guidelines, removed the obsolete#include <pybind11/smart_holder.h>and the following deprecated macros from the codebase:PYBIND11_SMART_HOLDER_TYPE_CASTERSThese are no longer needed with the latest
pybind11.Result
These changes resolve the build errors encountered when running
./open_spiel/scripts/build_and_run_tests.sh, ensuring compatibility with the currentpybind11masterbranch.Please review and let me know if additional adjustments are needed!