[hermes] Get tests passing again #3018
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on stabilizing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to get the tests passing again. It includes a refactoring of impl path generation in parse.rs and improves the redaction logic in transform.rs to preserve function body braces, which is a good change. My review includes a couple of suggestions: a minor idiomatic improvement in transform.rs, and a comment on the testing strategy of adding a dummy function across many test fixtures, which seems like a workaround for a potential issue in hermes when handling crates with no annotated items. A number of tests are also updated to be expected failures, which may be intentional to highlight existing bugs.
| for byte in &mut buffer[span.byte_range()] { | ||
| pub fn apply_edits(buffer: &mut [u8], edits: &[Range<usize>]) { | ||
| for range in edits { | ||
| for byte in &mut buffer[range.clone()] { |
There was a problem hiding this comment.
Since Range<usize> is a Copy type, you can dereference range directly instead of calling clone(). This is slightly more idiomatic.
| for byte in &mut buffer[range.clone()] { | |
| for byte in &mut buffer[*range] { |
| /// ```lean | ||
| /// ``` | ||
| fn _hermes_dummy() {} |
There was a problem hiding this comment.
This dummy function with a lean block is being added to many test fixtures. While this likely fixes the tests, it seems like a workaround. It suggests that hermes might not handle crates with no annotated items gracefully. It might be better to fix hermes to support this case, which would allow removing these dummy functions from the test fixtures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G60bb1cd41a5fade3144a05f2bdafb2a670059e03 #3018 +/- ##
==========================================================================
Coverage 91.87% 91.87%
==========================================================================
Files 20 20
Lines 6057 6057
==========================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
G3db3762006cf6333a7112b668f747072f8bb477b
branch
from
e17001b to
bd320db
Compare
joshlf
force-pushed
the
G60bb1cd41a5fade3144a05f2bdafb2a670059e03
branch
from
8f20400 to
f187d94
Compare
joshlf
force-pushed
the
G60bb1cd41a5fade3144a05f2bdafb2a670059e03
branch
from
f187d94 to
5660a8c
Compare
joshlf
force-pushed
the
G3db3762006cf6333a7112b668f747072f8bb477b
branch
from
bd320db to
76a916e
Compare
gherrit-pr-id: G3db3762006cf6333a7112b668f747072f8bb477b
joshlf
force-pushed
the
G60bb1cd41a5fade3144a05f2bdafb2a670059e03
branch
from
5660a8c to
ff70bf6
Compare
joshlf
force-pushed
the
G3db3762006cf6333a7112b668f747072f8bb477b
branch
from
76a916e to
81f4cda
Compare
2 participants
mod foo;declarations #3008Latest Update: v19 — Compare vs v18
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G3db3762006cf6333a7112b668f747072f8bb477b && git checkout -b pr-G3db3762006cf6333a7112b668f747072f8bb477b FETCH_HEADCheckout
git fetch origin refs/heads/G3db3762006cf6333a7112b668f747072f8bb477b && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G3db3762006cf6333a7112b668f747072f8bb477b && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.