[hermes] Take responsibility for all terminal UI #3019
+20,178
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2026
Contributor
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines how compiler diagnostics are presented to the user within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces a robust mechanism for mapping compiler diagnostics from the shadow build directory back to the user's source directory, which is a significant improvement for usability. The implementation uses miette for high-quality error reporting and handles path mapping and source caching effectively. I've noted a small redundancy in the diagnostic rendering logic that can be simplified.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G3db3762006cf6333a7112b668f747072f8bb477b #3019 +/- ##
==========================================================================
Coverage 91.87% 91.87%
==========================================================================
Files 20 20
Lines 6057 6057
==========================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d
branch
2 times, most recently
from
d0afaee to
0062c3c
Compare
joshlf
force-pushed
the
G3db3762006cf6333a7112b668f747072f8bb477b
branch
from
e17001b to
bd320db
Compare
joshlf
force-pushed
the
Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d
branch
from
0062c3c to
6b62149
Compare
This was referenced Feb 10, 2026
joshlf
force-pushed
the
Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d
branch
2 times, most recently
from
8771c47 to
d46c4e1
Compare
joshlf
force-pushed
the
G3db3762006cf6333a7112b668f747072f8bb477b
branch
from
bd320db to
76a916e
Compare
joshlf
force-pushed
the
Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d
branch
from
d46c4e1 to
4a6fb49
Compare
joshlf
changed the title
joshlf
force-pushed
the
Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d
branch
from
4a6fb49 to
c0f128f
Compare
Invoke `charon` using `--message-format=json`. Intercept all tool output and render our own unified terminal UI. TODO: Review this PR in depth. gherrit-pr-id: Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d
joshlf
force-pushed
the
Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d
branch
from
c0f128f to
e78478d
Compare
This was referenced Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke
charonusing--message-format=json. Intercept all tool outputand render our own unified terminal UI.
TODO: Review this PR in depth.
This PR is on branch hermes.
unsaferedaction #3034mod foo;declarations #3008Latest Update: v19 — Compare vs v18
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d && git checkout -b pr-Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d FETCH_HEADCheckout
git fetch origin refs/heads/Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gd1a7f9c4436f266d37e83ebc2310f5a99a73d24d && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.