[hermes] Clean up after removing shadow crate support

[joshlf]

---

This PR is on branch hermes.

• 👉 [hermes] Clean up after removing shadow crate support #3038
• 　  [hermes] Finalize removal of shadow crate code #3037
• 　  [hermes] Remove diagnostic path mapping from shadow copy #3036
• 　  [hermes] Stop copying shadow crate; run in-place #3035
• 　  [hermes] Disable unsafe redaction #3034
• 　  [hermes] Take responsibility for all terminal UI #3019
• 　  [hermes] Get tests passing again #3018
• 　  [hermes] Add some tests for Charon invocation #3015
• 　  [hermes] Add Charon step #3014
• 　  [hermes] Isolate shadow crate from other artifacts #3013
• 　  [hermes] Add some trace/debug logging #3012
• 　  [hermes] Add one more UI test #3011
• 　  [hermes] Add fixture testing #3010
• 　  [hermes] Finish shadow crate creation #3009
• 　  [hermes] Discover mod foo; declarations #3008
• 　  [hermes] Resolve Cargo and Hermes target dirs #3007
• 　  [hermes] Add shadow copy creation #3006
• 　  [hermes] Add package/target/root resolution #3005
• 　  [hermes] Add source code transformation #3004
• 　  [hermes] Add UI testing #3003
• 　  [hermes] Initial commit of parser #3002

⬇️ Download this PR

Branch

git fetch origin refs/heads/Gldfbyjdbfd3uolcvhjysepgbx472jv5a && git checkout -b pr-Gldfbyjdbfd3uolcvhjysepgbx472jv5a FETCH_HEAD

Checkout

git fetch origin refs/heads/Gldfbyjdbfd3uolcvhjysepgbx472jv5a && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gldfbyjdbfd3uolcvhjysepgbx472jv5a && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gldfbyjdbfd3uolcvhjysepgbx472jv5a

Stacked PRs enabled by GHerrit.

[gemini-code-assist]

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on removing the remnants of shadow crate support from the Hermes tool. It updates the data structures and logic to directly use the original Cargo.toml files instead of relying on rewritten copies. Additionally, test fixtures are adjusted to align with these changes, ensuring correct file path handling.

Highlights

• Shadow Crate Removal: This PR cleans up the codebase after the removal of shadow crate support, which was used for rewriting Cargo.toml files.
• Manifest Path: The HermesTarget struct now includes the path to the Cargo.toml manifest file.
• Test Updates: Test fixtures were updated to reflect the removal of shadow crate paths.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity

• The primary goal of this PR is to clean up the codebase after the removal of shadow crate support.
• The changes involve modifying the HermesTarget struct and updating test fixtures.
• The removal of shadow crate support simplifies the tool's logic and reduces complexity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (398dc36) to head (0556c73).

Additional details and impacted files

@@                        Coverage Diff                         @@
##           Gtzihj5ol6a2xgdnfdresbbnwzaw25quk    #3038   +/-   ##
==================================================================
  Coverage                              91.87%   91.87%           
==================================================================
  Files                                     20       20           
  Lines                                   6057     6057           
==================================================================
  Hits                                    5565     5565           
  Misses                                   492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request provides a nice cleanup by removing the concept of "shadow crates". The changes are consistent across the codebase, including application logic, tests, and test data, which simplifies the overall implementation. Key improvements include storing the manifest_path directly, removing now-redundant functions like find_package_root, and simplifying test setup. The refactoring in process_file_recursive also enhances readability. Overall, these changes improve code maintainability, and I have no further suggestions.